From: "David S. Miller" <davem@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: jmorris@redhat.com, netdev@oss.sgi.com
Subject: Re: [CRYPTO] Fix stack overrun in crypt()
Date: Wed, 21 Jul 2004 14:58:15 -0700 [thread overview]
Message-ID: <20040721145815.307c5e39.davem@redhat.com> (raw)
In-Reply-To: <20040715114840.GA1325@gondor.apana.org.au>
On Thu, 15 Jul 2004 21:48:40 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> The stack allocation in crypt() is bogus as whether tmp_src/tmp_dst
> is used is determined by factors unrelated to nbytes and
> src->length/dst->length.
>
> Since the condition for whether tmp_src/tmp_dst are used is very
> complex, let's allocate them always instead of guessing.
>
> This fixes a number of weird crashes including those AES crashes
> that people have been seeing with the 2.4 backport + ipt_conntrack.
Applied, thanks Herbert.
> PS I think someone should double-check the logic in the scatterwalk
> stuff, especially the whichbuf bits.
I've looked at this before, when it went in, but I'll double-
check it now.
next prev parent reply other threads:[~2004-07-21 21:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-15 11:48 [CRYPTO] Fix stack overrun in crypt() Herbert Xu
2004-07-16 15:27 ` James Morris
2004-07-17 7:43 ` Herbert Xu
2004-07-17 9:48 ` Herbert Xu
2004-07-21 21:58 ` David S. Miller [this message]
2004-07-21 22:02 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040721145815.307c5e39.davem@redhat.com \
--to=davem@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=jmorris@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.