From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Domsch Subject: Re: [3/3] add MODULE_VERSION to drivers/scsi Date: Thu, 22 Jul 2004 08:38:55 -0500 Sender: linux-scsi-owner@vger.kernel.org Message-ID: <20040722133855.GA30314@lists.us.dell.com> References: <20040721220111.GA16608@lists.us.dell.com> <20040721220258.GD16608@lists.us.dell.com> <20040722122823.GC4227@parcelfarce.linux.theplanet.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from lists.us.dell.com ([143.166.224.162]:2413 "EHLO lists.us.dell.com") by vger.kernel.org with ESMTP id S265795AbUGVNkM (ORCPT ); Thu, 22 Jul 2004 09:40:12 -0400 Content-Disposition: inline In-Reply-To: <20040722122823.GC4227@parcelfarce.linux.theplanet.co.uk> List-Id: linux-scsi@vger.kernel.org To: Matthew Wilcox Cc: linux-scsi@vger.kernel.org, jgarzik@pobox.com On Thu, Jul 22, 2004 at 01:28:23PM +0100, Matthew Wilcox wrote: > > +#define SYM_VERSION "2.1.18j" > > +#define SYM_DRIVER_NAME "sym-" SYM_VERSION > > Umm. No. This is ridiculous. I'm not having a 51 line copyright message > with 2 lines of #define. It's not even clear to me that these two lines > have artisitic merit. How about putting these defines in sym_defs.h, > at the top? It's already included in both sym_glue.c and sym_hipd.c by > being included by sym_glue.h. Indeed, point well taken. Done, they're now at the top of defines in sym_defs.h, and I've updated my BK tree accordingly. Thanks, Matt -- Matt Domsch Sr. Software Engineer, Lead Engineer Dell Linux Solutions linux.dell.com & www.dell.com/linux Linux on Dell mailing lists @ http://lists.us.dell.com