From: Andrew Morton <akpm@osdl.org>
To: Ryan Arnold <rsa@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, paulus@samba.org
Subject: Re: [announce] HVCS for inclusion in 2.6 tree
Date: Thu, 22 Jul 2004 19:29:52 -0700 [thread overview]
Message-ID: <20040722192952.2cc0bd05.akpm@osdl.org> (raw)
In-Reply-To: <1090528007.3161.7.camel@localhost>
Ryan Arnold <rsa@us.ibm.com> wrote:
>
>
> +/* This function is executed by the driver "rescan" sysfs entry */
> +static int hvcs_rescan_devices_list(void)
> +{
> + struct hvcs_struct *hvcsd = NULL;
> + unsigned long flags;
> +
> + /* Locking issues? */
> + list_for_each_entry(hvcsd, &hvcs_structs, next) {
>
Well yes. hvcs_structs definitely needs locking. If it's easy to do then
slapping a semaphore around it should be a five-minute job. If it's hard
to do then now is the best time to do it, while the code is fresh in one's
mind, no?
prev parent reply other threads:[~2004-07-22 23:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-14 15:42 [announce] HVCS for inclusion in 2.6 tree Ryan Arnold
2004-07-18 2:00 ` Paul Mackerras
2004-07-19 15:54 ` Ryan Arnold
2004-07-22 20:26 ` Ryan Arnold
2004-07-23 1:57 ` Andrew Morton
2004-07-26 14:41 ` Ryan Arnold
2004-07-23 2:16 ` Andrew Morton
2004-07-27 20:08 ` [announce][draft3] " Ryan Arnold
2004-07-27 22:50 ` Randy.Dunlap
2004-07-28 16:39 ` Ryan Arnold
2004-07-28 20:12 ` Randy.Dunlap
2004-07-28 20:18 ` [announce][draft4] " Ryan Arnold
2004-07-29 17:41 ` Jeff Garzik
2004-08-02 14:24 ` Ryan Arnold
2004-07-28 20:36 ` [announce][draft3] " Paul Mackerras
2004-07-28 17:00 ` Ryan Arnold
2004-07-27 23:02 ` Randy.Dunlap
2004-07-23 2:21 ` [announce] " Andrew Morton
2004-07-26 12:57 ` Ryan Arnold
2004-07-23 2:29 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040722192952.2cc0bd05.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=rsa@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.