All of lore.kernel.org
 help / color / mirror / Atom feed
From: maximilian attems <janitor@sternwelten.at>
To: jffs-dev@axis.com
Cc: linux-kernel@vger.kernel.org
Subject: [patch-kj] use list_for_each() in fs/jffs/intrep.c
Date: Fri, 23 Jul 2004 17:55:28 +0200	[thread overview]
Message-ID: <20040723155528.GQ1795@stro.at> (raw)


Use list_for_each() where applicable
- for (list = ymf_devs.next; list != &ymf_devs; list = list->next) {
+ list_for_each(list, &ymf_devs) {
pure cosmetic change, defined as a preprocessor macro in:
include/linux/list.h

applies cleanly to 2.6.8-rc2

From: Domen Puncer <domen@coderock.org>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>



---

 linux-2.6.7-bk20-max/fs/jffs/intrep.c |   13 ++++++-------
 1 files changed, 6 insertions(+), 7 deletions(-)

diff -puN fs/jffs/intrep.c~list_for_each-fs-jffs fs/jffs/intrep.c
--- linux-2.6.7-bk20/fs/jffs/intrep.c~list_for_each-fs-jffs	2004-07-11 14:41:04.000000000 +0200
+++ linux-2.6.7-bk20-max/fs/jffs/intrep.c	2004-07-11 14:41:04.000000000 +0200
@@ -1623,7 +1623,7 @@ jffs_find_file(struct jffs_control *c, _
 
 	D3(printk("jffs_find_file(): ino: %u\n", ino));
 
-	for (tmp = c->hash[i].next; tmp != &c->hash[i]; tmp = tmp->next) {
+	list_for_each(tmp, &c->hash[i]) {
 		f = list_entry(tmp, struct jffs_file, hash);
 		if (ino != f->ino)
 			continue;
@@ -2021,11 +2021,10 @@ jffs_foreach_file(struct jffs_control *c
 
 	for (pos = 0; pos < c->hash_len; pos++) {
 		struct list_head *p, *next;
-		for (p = c->hash[pos].next; p != &c->hash[pos]; p = next) {
-			/* We need a reference to the next file in the
-			   list because `func' might remove the current
-			   file `f'.  */
-			next = p->next;
+
+		/* We must do _safe, because 'func' might remove the
+		   current file 'f' from the list.  */
+		list_for_each_safe(p, next, &c->hash[pos]) {
 			r = func(list_entry(p, struct jffs_file, hash));
 			if (r < 0)
 				return r;
@@ -2590,7 +2589,7 @@ jffs_print_hash_table(struct jffs_contro
 	printk("JFFS: Dumping the file system's hash table...\n");
 	for (i = 0; i < c->hash_len; i++) {
 		struct list_head *p;
-		for (p = c->hash[i].next; p != &c->hash[i]; p = p->next) {
+		list_for_each(p, &c->hash[i]) {
 			struct jffs_file *f=list_entry(p,struct jffs_file,hash);
 			printk("*** c->hash[%u]: \"%s\" "
 			       "(ino: %u, pino: %u)\n",


             reply	other threads:[~2004-07-23 16:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-23 15:55 maximilian attems [this message]
2004-07-23 16:17 ` [patch-kj] use list_for_each() in fs/jffs/intrep.c Christoph Hellwig
2004-07-23 19:02   ` Domen Puncer
2004-07-29 11:33     ` Domen Puncer
2004-07-25 12:15   ` maximilian attems

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040723155528.GQ1795@stro.at \
    --to=janitor@sternwelten.at \
    --cc=jffs-dev@axis.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.