From: Dominik Brodowski <linux@dominikbrodowski.de>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: cpufreq list <cpufreq@www.linux.org.uk>
Subject: Re: my dothan didn't work with cpufreq...
Date: Fri, 23 Jul 2004 21:38:59 +0200 [thread overview]
Message-ID: <20040723193859.GC8441@dominikbrodowski.de> (raw)
In-Reply-To: <1090517665.5267.9.camel@ixodes.goop.org>
On Thu, Jul 22, 2004 at 10:34:25AM -0700, Jeremy Fitzhardinge wrote:
> > > +static const struct cpu_id cpu_ids[] = {
> > > + [CPU_BANIAS] = { X86_VENDOR_INTEL, 6, 9, 5 },
> > > + [CPU_DOTHAN_A1] = { X86_VENDOR_INTEL, 6, 13, 1 },
> > > + [CPU_DOTHAN_B0] = { X86_VENDOR_INTEL, 6, 13, 6 },
> >
> > Hm, I'm unsure whether this is proper CodingStyle... IIRC, much effort was
> > spent in converting such { }s to include the respective "fields", like
> > { .x86_vendor = X86_VENDOR_INTEL, x86_family = 6 ...
> > and so on.
>
> For a tiny little structure like this, which is defined immediately
> above, this is fine. (CodingStyle makes no mention of structure
> initialization.)
Again IIRC, it's less about CodingStyle and more about some GCC 3.?
warnings? Though, gcc 3.3.4 doesn't complain...
Dominik
next prev parent reply other threads:[~2004-07-23 19:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-12 20:54 my dothan didn't work with cpufreq Damien Marchal
2004-07-13 9:49 ` Dominik Brodowski
2004-07-14 10:50 ` Damien Marchal
2004-07-16 8:19 ` Dominik Brodowski
2004-07-22 1:55 ` Jeremy Fitzhardinge
2004-07-22 6:04 ` Dominik Brodowski
2004-07-22 6:56 ` Jeremy Fitzhardinge
2004-07-22 9:31 ` Dominik Brodowski
2004-07-22 17:34 ` Jeremy Fitzhardinge
2004-07-23 19:38 ` Dominik Brodowski [this message]
2004-07-24 1:27 ` Jeremy Fitzhardinge
2004-07-24 7:06 ` Dominik Brodowski
2004-08-02 19:26 ` Dave Jones
2004-08-02 20:17 ` Jeremy Fitzhardinge
2004-08-02 20:29 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040723193859.GC8441@dominikbrodowski.de \
--to=linux@dominikbrodowski.de \
--cc=cpufreq@www.linux.org.uk \
--cc=jeremy@goop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.