From: maximilian attems <janitor@sternwelten.at>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Kernel-janitors] [PATCH] drivers/char/esp.c MIN/MAX removal
Date: Sun, 25 Jul 2004 12:26:08 +0000 [thread overview]
Message-ID: <20040725122608.GC1756@stro.at> (raw)
In-Reply-To: <40E819B9.60604@gmx.net>
[-- Attachment #1: Type: text/plain, Size: 1574 bytes --]
On Sun, 04 Jul 2004, Michael Veeck wrote:
> Patch (against 2.6.7) removes unnecessary min/max macros and changes
> calls to use kernel.h macros instead.
>
> Feedback is always welcome
> Michael
>
>
>
>
>
>
>
> --- linux-2.6.7-old/drivers/char/esp.c 2004-07-04 11:04:13.000000000 +0200
> +++ linux-2.6.7-new/drivers/char/esp.c 2004-07-04 15:03:22.346728056 +0200
> @@ -19,7 +19,7 @@
> *
> * rs_set_termios fixed to look also for changes of the input
> * flags INPCK, BRKINT, PARMRK, IGNPAR and IGNBRK.
> - * Bernd Anh?upl 05/17/96.
> + * Bernd Anh???pl 05/17/96.
> *
> * --- End of notices from serial.c ---
> *
utf8?
> @@ -140,7 +140,7 @@
>
> static void change_speed(struct esp_struct *info);
> static void rs_wait_until_sent(struct tty_struct *, int);
> -
> +
> /*
> * The ESP card has a clock rate of 14.7456 MHz (that is, 2**ESPC_SCALE
> * times the normal 1.8432 Mhz clock of most serial boards).
space fix
> @@ -150,10 +150,6 @@
> /* Standard COM flags (except for COM4, because of the 8514 problem) */
> #define STD_COM_FLAGS (ASYNC_BOOT_AUTOCONF | ASYNC_SKIP_TEST)
>
> -#ifndef MIN
> -#define MIN(a,b) ((a) < (b) ? (a) : (b))
> -#endif
> -
> /*
> * tmp_buf is used as a temporary buffer by serial_write. We need to
> * lock it in case the memcpy_fromfs blocks while swapping in a page,
real min max stuff!
please do not random "fixes" in parallell,
if a file really needs white space fixes use automatic tool for that.
thanks maks
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2004-07-25 12:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-03 15:05 [Kernel-janitors] [PATCH] drivers/char/epca.c MIN/MAX removal Michael Veeck
2004-07-03 15:05 ` [Kernel-janitors] [PATCH] drivers/char/esp.c " Michael Veeck
2004-07-25 12:26 ` maximilian attems [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040725122608.GC1756@stro.at \
--to=janitor@sternwelten.at \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.