Re: [PATCH] atyfb: vblank irq support

["Antonino A. Daplas" <adaplas@hotpop.com>]

On Monday 26 July 2004 02:36, Alexander Kern wrote:
> Am Sonntag, 25. Juli 2004 02:03 schrieb Antonino A. Daplas:
> > On Sunday 25 July 2004 07:12, Alexander Kern wrote:
> > > P.S. Now the last consumer from fb_load_cursor_image is neo driver.
> > > Should we drop this function, it's buggy!
> >
> > We should.  fb_load_cursor_image() cannot be generic.
>
> fine, do you make it for neo driver?

I think James did it for neofb. 

We can just move it to one of neofb's file and rename it 
neofb_load_cursor_image().

>
> > > Steel on my TODO list:
> > >
> > > Issue with 16bpp mode, brocken boot logo, fbi has problems too.
> >
> > 1. aty128fb_setcolreg has this lines:
> >
> > 		case 16:
> > 			pal[regno] = (regno << 11) | (regno << 6) | regno;
> > 			break;
> >
> > Shouldn't it be?
> >
> > 		pal[regno] = (regno << 11) | (regno << 5) | regno;
>
> Maybe, but I work on mach64 driver. In atyfb_base.c#2671 it is really
> pal[regno] = (regno << 11) | (regno << 5) | regno;

Ok, I got confused since I was looking at a different patchset. 

Tony




-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=4721&alloc_id=10040&op=click