All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Aravamudan <nacc@us.ibm.com>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] [PATCH] message/mptbase: replace
Date: Mon, 26 Jul 2004 23:17:28 +0000	[thread overview]
Message-ID: <20040726231728.GZ1897@us.ibm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 3158 bytes --]

I would appreciate any comments from the janitors list. This is one (of
many) cases where I made a decision about replacing

set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(some_time);

with

msleep(jiffies_to_msecs(some_time));

msleep() is not exactly the same as the previous code, but I only did
this replacement where I thought long delays were *desired*. If this is
not the case here, then just disregard this patch. 

Thanks,
Nish



Applys-to: 2.6.7

Description: Replace schedule_timeout() with msleep() to guarantee the
task delays for the desired time.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>


--- linux-vanilla/drivers/message/fusion/mptbase.c	2004-06-16 05:19:01.000000000 +0000
+++ linux-dev/drivers/message/fusion/mptbase.c	2004-07-12 18:56:59.000000000 +0000
@@ -3117,12 +3117,10 @@ mpt_downloadboot(MPT_ADAPTER *ioc, int s
 		CHIPREG_WRITE32(&ioc->chip->WriteSequence, MPI_WRSEQ_5TH_KEY_VALUE);
 
 		/* wait 100 msec */
-		if (sleepFlag == CAN_SLEEP) {
-			set_current_state(TASK_INTERRUPTIBLE);
-			schedule_timeout(100 * HZ / 1000);
-		} else {
+		if (sleepFlag == CAN_SLEEP)
+			msleep (100);
+		else
 			mdelay (100);
-		}
 
 		count++;
 		if (count > 20) {
@@ -3351,12 +3349,10 @@ KickStart(MPT_ADAPTER *ioc, int force, i
 		 */
 		SendIocReset(ioc, MPI_FUNCTION_IOC_MESSAGE_UNIT_RESET, sleepFlag);
 
-		if (sleepFlag == CAN_SLEEP) {
-			set_current_state(TASK_INTERRUPTIBLE);
-			schedule_timeout(HZ);
-		} else {
+		if (sleepFlag == CAN_SLEEP)
+			msleep (1000);
+		else
 			mdelay (1000);
-		}
 	}
 
 	hard_reset_done = mpt_diag_reset(ioc, force, sleepFlag);
@@ -3445,12 +3441,10 @@ mpt_diag_reset(MPT_ADAPTER *ioc, int ign
 			CHIPREG_WRITE32(&ioc->chip->WriteSequence, MPI_WRSEQ_5TH_KEY_VALUE);
 
 			/* wait 100 msec */
-			if (sleepFlag == CAN_SLEEP) {
-				set_current_state(TASK_INTERRUPTIBLE);
-				schedule_timeout(100 * HZ / 1000);
-			} else {
+			if (sleepFlag == CAN_SLEEP)
+				msleep (100);
+			else
 				mdelay (100);
-			}
 
 			count++;
 			if (count > 20) {
@@ -3538,12 +3532,10 @@ mpt_diag_reset(MPT_ADAPTER *ioc, int ign
 				}
 
 				/* wait 1 sec */
-				if (sleepFlag == CAN_SLEEP) {
-					set_current_state(TASK_INTERRUPTIBLE);
-					schedule_timeout(HZ);
-				} else {
+				if (sleepFlag == CAN_SLEEP)
+					msleep (1000);
+				else
 					mdelay (1000);
-				}
 			}
 			if ((count = mpt_downloadboot(ioc, sleepFlag)) < 0) {
 				printk(KERN_WARNING MYNAM
@@ -3566,12 +3558,10 @@ mpt_diag_reset(MPT_ADAPTER *ioc, int ign
 				}
 
 				/* wait 1 sec */
-				if (sleepFlag == CAN_SLEEP) {
-					set_current_state(TASK_INTERRUPTIBLE);
-					schedule_timeout(HZ);
-				} else {
+				if (sleepFlag == CAN_SLEEP)
+					msleep (1000);
+				else
 					mdelay (1000);
-				}
 			}
 		}
 	}
@@ -3600,12 +3590,10 @@ mpt_diag_reset(MPT_ADAPTER *ioc, int ign
 		CHIPREG_WRITE32(&ioc->chip->WriteSequence, MPI_WRSEQ_5TH_KEY_VALUE);
 
 		/* wait 100 msec */
-		if (sleepFlag == CAN_SLEEP) {
-			set_current_state(TASK_INTERRUPTIBLE);
-			schedule_timeout(100 * HZ / 1000);
-		} else {
+		if (sleepFlag == CAN_SLEEP)
+			msleep (100);
+		else
 			mdelay (100);
-		}
 
 		count++;
 		if (count > 20) {

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

             reply	other threads:[~2004-07-26 23:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-26 23:17 Nishanth Aravamudan [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-08-14 18:59 [Kernel-janitors] [PATCH] message/mptbase: replace maximilian attems

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040726231728.GZ1897@us.ibm.com \
    --to=nacc@us.ibm.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.