From: Gerd Knorr <kraxel@bytesex.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Frederik <frederik@padjen.de>, linux-kernel@vger.kernel.org
Subject: Re: Fw: Oops when modprobing cx8800
Date: Tue, 27 Jul 2004 08:48:25 +0200 [thread overview]
Message-ID: <20040727064824.GB16853@bytesex> (raw)
In-Reply-To: <20040725183038.108ffd7c.akpm@osdl.org>
On Sun, Jul 25, 2004 at 06:30:38PM -0700, Andrew Morton wrote:
>
> hm, odd.
> Jul 21 15:30:21 athene kernel: [<c020a377>] vsprintf+0x27/0x30
> Jul 21 15:30:21 athene kernel: [<c020a39f>] sprintf+0x1f/0x30
> Jul 21 15:30:21 athene kernel: [<d0cc1078>] cx8800_initdev+0x78/0x7a0
The only bug I'm aware of which is still in 2.6.8-rc1+ and might be this
is that the card= insmod option lacks a range check (patch below), so
passing some insane high value might kill the driver. It shouldn't
happen with a simple "insmod cx88" + card autodetect through.
If it is something else -- no idea.
> (This driver should be using kthread for the kernel thread management btw)
Yup, and some other v4l drivers as well ...
Just didn't know kthread exists before OLS ;)
Gerd
diff -u -p -r1.27 -r1.28
--- cx88-video.c 22 Jul 2004 13:54:28 -0000 1.27
+++ cx88-video.c 23 Jul 2004 01:06:12 -0000 1.28
@@ -2382,7 +2382,9 @@ static int __devinit cx8800_initdev(stru
}
/* board config */
- dev->board = card[cx8800_devcount];
+ dev->board = UNSET;
+ if (card[cx8800_devcount] < cx88_bcount)
+ dev->board = card[cx8800_devcount];
for (i = 0; UNSET == dev->board && i < cx88_idcount; i++)
if (pci_dev->subsystem_vendor == cx88_subids[i].subvendor &&
pci_dev->subsystem_device == cx88_subids[i].subdevice)
parent reply other threads:[~2004-07-27 7:00 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20040725183038.108ffd7c.akpm@osdl.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040727064824.GB16853@bytesex \
--to=kraxel@bytesex.org \
--cc=akpm@osdl.org \
--cc=frederik@padjen.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.