All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Knorr <kraxel@bytesex.org>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] Re: [PATCH] video/bttv-driver: replace
Date: Tue, 27 Jul 2004 06:59:59 +0000	[thread overview]
Message-ID: <20040727065959.GA17029@bytesex> (raw)
In-Reply-To: <20040727062650.GG8798@bytesex>

[-- Attachment #1: Type: text/plain, Size: 607 bytes --]

On Tue, Jul 27, 2004 at 08:26:50AM +0200, Gerd Knorr wrote:
> On Mon, Jul 26, 2004 at 03:47:30PM -0700, Nishanth Aravamudan wrote:
> > set_current_state(TASK_INTERRUPTIBLE);
> > schedule_timeout(some_time);

> > msleep(jiffies_to_msecs(some_time));
> > 
> > msleep() is not exactly the same as the previous code,
> 
> How does it differ?  And what exactly is the point in replacing it?

Especially as msleep() does busy waits (unless I've missed something)
whereas schedule_timeout() doesn't?  I'd like to veto this one, and
the other ones touching video4linux drivers as well.

  Gerd

-- 
return -ENOSIG;

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

  reply	other threads:[~2004-07-27  6:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-27  6:26 [Kernel-janitors] Re: [PATCH] video/bttv-driver: replace Gerd Knorr
2004-07-27  6:59 ` Gerd Knorr [this message]
2004-07-27 15:43 ` Nishanth Aravamudan
2004-07-27 15:53 ` Nishanth Aravamudan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040727065959.GA17029@bytesex \
    --to=kraxel@bytesex.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.