From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266333AbUG0IH1 (ORCPT ); Tue, 27 Jul 2004 04:07:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266335AbUG0IH1 (ORCPT ); Tue, 27 Jul 2004 04:07:27 -0400 Received: from mx1.elte.hu ([157.181.1.137]:42380 "EHLO mx1.elte.hu") by vger.kernel.org with ESMTP id S266333AbUG0IFL (ORCPT ); Tue, 27 Jul 2004 04:05:11 -0400 Date: Tue, 27 Jul 2004 10:06:12 +0200 From: Ingo Molnar To: Rudo Thomas Cc: Lee Revell , Jens Axboe , William Lee Irwin III , Lenar L?hmus , linux-kernel , Andrew Morton Subject: Re: no luck with max_sectors_kb (Re: voluntary-preempt-2.6.8-rc2-J4) Message-ID: <20040727080612.GA7277@elte.hu> References: <1090795742.719.4.camel@mindpipe> <20040726082330.GA22764@elte.hu> <1090830574.6936.96.camel@mindpipe> <20040726083537.GA24948@elte.hu> <20040726100103.GA29072@elte.hu> <20040726101536.GA29408@elte.hu> <20040726204228.GA1231@ss1000.ms.mff.cuni.cz> <20040726205741.GA27527@elte.hu> <20040726225009.GA2369@ss1000.ms.mff.cuni.cz> <20040727064345.GA5594@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040727064345.GA5594@elte.hu> User-Agent: Mutt/1.4.1i X-ELTE-SpamVersion: MailScanner 4.31.6-itk1 (ELTE 1.2) SpamAssassin 2.63 ClamAV 0.73 X-ELTE-VirusStatus: clean X-ELTE-SpamCheck: no X-ELTE-SpamCheck-Details: score=-4.9, required 5.9, autolearn=not spam, BAYES_00 -4.90 X-ELTE-SpamLevel: X-ELTE-SpamScore: -4 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org * Ingo Molnar wrote: > ok, dm (and some other layered block drivers) set q->max_sectors > directly instead of using blk_queue_max_sectors(). does the patch below fix your DM problems? Ingo --- linux/drivers/md/dm-table.c.orig +++ linux/drivers/md/dm-table.c @@ -825,7 +825,7 @@ void dm_table_set_restrictions(struct dm * Make sure we obey the optimistic sub devices * restrictions. */ - q->max_sectors = t->limits.max_sectors; + blk_queue_max_sectors(q, t->limits.max_sectors); q->max_phys_segments = t->limits.max_phys_segments; q->max_hw_segments = t->limits.max_hw_segments; q->hardsect_size = t->limits.hardsect_size;