From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Aravamudan Date: Tue, 27 Jul 2004 21:08:21 +0000 Subject: [Kernel-janitors] [PATCH] parport/ieee1284: replace Message-Id: <20040727210821.GL3471@us.ibm.com> MIME-Version: 1 Content-Type: multipart/mixed; boundary="===============84777438150051176==" List-Id: To: kernel-janitors@vger.kernel.org --===============84777438150051176== Content-Type: text/plain; charset=us-ascii Content-Disposition: inline I would appreciate any comments from the janitors list. This is one (of many) cases where I made a decision about replacing set_current_state(TASK_INTERRUPTIBLE); schedule_timeout(some_time); with msleep(jiffies_to_msecs(some_time)); msleep() is not exactly the same as the previous code, but I only did this replacement where I thought long delays were *desired*. If this is not the case here, then just disregard this patch. Thanks, Nish Applys-to: 2.6.7 Description: Uses msleep() instead of schedule_timeout() to guarantee the task delays the desired time. Signed-off-by: Nishanth Aravamudan --- linux-vanilla/drivers/parport/ieee1284.c 2004-06-16 05:18:57.000000000 +0000 +++ linux-dev/drivers/parport/ieee1284.c 2004-07-12 21:46:18.000000000 +0000 @@ -212,13 +212,11 @@ int parport_wait_peripheral(struct parpo if ((status & mask) == result) return 0; - if (!ret) { + if (!ret) /* parport_wait_event didn't time out, but the * peripheral wasn't actually ready either. * Wait for another 10ms. */ - __set_current_state (TASK_INTERRUPTIBLE); - schedule_timeout ((HZ+ 99) / 100); - } + msleep(10); } return 1; --===============84777438150051176== Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline _______________________________________________ Kernel-janitors mailing list Kernel-janitors@lists.osdl.org http://lists.osdl.org/mailman/listinfo/kernel-janitors --===============84777438150051176==--