From: Nishanth Aravamudan <nacc@us.ibm.com>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] [PATCH] usb/dabusb: insert set_current_state()
Date: Tue, 27 Jul 2004 23:11:09 +0000 [thread overview]
Message-ID: <20040727231109.GK4679@us.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
I would appreciate any comments from the janitors list.
Applys-to: 2.6.7
Description: Move non-blocking conditional check outside while-loop.
Insert set_current_stateo() so schedule_timeout() functions as expected.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- linux-vanilla/drivers/usb/media/dabusb.c 2004-06-16 05:19:36.000000000 +0000
+++ linux-dev/drivers/usb/media/dabusb.c 2004-07-13 20:36:32.000000000 +0000
@@ -592,12 +592,14 @@ static int dabusb_open (struct inode *in
dbg("dabusb_open");
down (&s->mutex);
+ if (file->f_flags & O_NONBLOCK) {
+ return -EBUSY;
+ }
+
while (!s->usbdev || s->opened) {
up (&s->mutex);
- if (file->f_flags & O_NONBLOCK) {
- return -EBUSY;
- }
+ set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout (HZ / 2);
if (signal_pending (current)) {
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next reply other threads:[~2004-07-27 23:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-27 23:11 Nishanth Aravamudan [this message]
2004-07-27 23:13 ` [Kernel-janitors] [PATCH] usb/dabusb: insert set_current_state() Nishanth Aravamudan
2004-07-28 16:44 ` Nishanth Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040727231109.GK4679@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.