All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@redhat.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Alan Cox <alan@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: PATCH: fix some 32bit isms
Date: Wed, 28 Jul 2004 12:27:03 -0400	[thread overview]
Message-ID: <20040728162703.GB4074@devserv.devel.redhat.com> (raw)
In-Reply-To: <20040728092334.74e0cfcd.akpm@osdl.org>

On Wed, Jul 28, 2004 at 09:23:34AM -0700, Andrew Morton wrote:
> Alan Cox <alan@redhat.com> wrote:
> >
> >  		printk(MYIOC_s_ERR_FMT 
> >   		     "Invalid IOC facts reply, msgLength=%d offsetof=%d!\n",
> >  -		     ioc->name, facts->MsgLength, (offsetof(IOCFactsReply_t,
> >  +		     ioc->name, facts->MsgLength, (int)(offsetof(IOCFactsReply_t,
> 
> printk expects %zd for a size_t

So I've now learned. I've been a bit out of touch with the 2.5/2.6 printk
evolution

> Some architectures will emit a warning here, and will perhaps print the
> wrong thing.  We need to print size_t's with %zd.  I'll fix that up.

Thanks


  reply	other threads:[~2004-07-28 16:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-28 13:59 PATCH: fix some 32bit isms Alan Cox
2004-07-28 15:42 ` H. Peter Anvin
2004-07-28 15:51 ` David S. Miller
2004-07-28 16:23 ` Andrew Morton
2004-07-28 16:27   ` Alan Cox [this message]
2004-08-06 22:53   ` H. Peter Anvin
2004-08-06 23:03     ` viro
2004-08-06 23:07       ` viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040728162703.GB4074@devserv.devel.redhat.com \
    --to=alan@redhat.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.