From: "David S. Miller" <davem@redhat.com>
To: James Morris <jmorris@redhat.com>
Cc: nakam@linux-ipv6.org, netdev@oss.sgi.com, herbert@gondor.apana.org.au
Subject: Re: [PATCH]Fix adding SA through netlink(xfrm_user)
Date: Wed, 28 Jul 2004 19:07:28 -0700 [thread overview]
Message-ID: <20040728190728.2dcf06f7.davem@redhat.com> (raw)
In-Reply-To: <Xine.LNX.4.44.0407281134500.11200-100000@dhcp83-76.boston.redhat.com>
On Wed, 28 Jul 2004 11:41:33 -0400 (EDT)
James Morris <jmorris@redhat.com> wrote:
> On Thu, 29 Jul 2004, Masahide Nakamura wrote:
>
> > When adding IPsec SA with PF_KEY (pfkey_add()),
> > xfrm_probe_algs() is called to make all algorithms valid.
> > However, it is missing to call it with netlink (xfrm_user) case and
> > it causes xfrm_aalg_get_byname() return NULL even if the name of
> > algorithm seems to be correct.
>
> Looks ok, but odd that this has not been picked up before.
As discovered, this never got picked up before mostly
because the most popular user of xfrm_user (Openswan)
is still using PF_KEY to probe the algorithms.
Patch applied, arigato Masahide-san.
prev parent reply other threads:[~2004-07-29 2:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-28 15:10 [PATCH]Fix adding SA through netlink(xfrm_user) Masahide Nakamura
2004-07-28 15:41 ` James Morris
2004-07-29 2:07 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040728190728.2dcf06f7.davem@redhat.com \
--to=davem@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=jmorris@redhat.com \
--cc=nakam@linux-ipv6.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.