From: Anton Blanchard <anton@samba.org>
To: Joel Schopp <jschopp@austin.ibm.com>
Cc: paulus@samba.org, akpm@osdl.org,
linuxppc64-dev@lists.linuxppc.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ppc64 SMT bugfix
Date: Thu, 29 Jul 2004 15:52:34 +1000 [thread overview]
Message-ID: <20040729055234.GF6456@krispykreme> (raw)
In-Reply-To: <4106A27C.3060306@austin.ibm.com>
Hi Joel,
Yep, looks good to me. Longer term we should allow an aribtrary number
of siblings but we can fix that when the cpu_to_sibling stuff goes in.
Anton
--
From: Joel Schopp <jschopp@austin.ibm.com>
This patch is fairly straightforward. maxcpus should be per SMT thread
and not per physical processor.
Signed-off-by: Joel Schopp <jschopp@austin.ibm.com>
Signed-off-by: Anton Blanchard <anton@samba.org>
diff -Nru a/arch/ppc64/kernel/smp.c b/arch/ppc64/kernel/smp.c
--- a/arch/ppc64/kernel/smp.c Tue Jul 27 13:44:45 2004
+++ b/arch/ppc64/kernel/smp.c Tue Jul 27 13:44:45 2004
@@ -422,7 +422,11 @@
}
maxcpus = ireg[num_addr_cell + num_size_cell];
- /* DRENG need to account for threads here too */
+
+ /* Double maxcpus for processors which have SMT capability */
+ if (cur_cpu_spec->cpu_features & CPU_FTR_SMT)
+ maxcpus *= 2;
+
if (maxcpus > NR_CPUS) {
printk(KERN_WARNING
prev parent reply other threads:[~2004-07-29 5:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-27 18:44 [PATCH] ppc64 SMT bugfix Joel Schopp
2004-07-29 5:52 ` Anton Blanchard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040729055234.GF6456@krispykreme \
--to=anton@samba.org \
--cc=akpm@osdl.org \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@lists.linuxppc.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.