From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 29 Jul 2004 17:18:13 +0200 To: Gustavo Barbieri Cc: Sven Luther , debian-kernel@lists.debian.org, linuxppc-dev@lists.linuxppc.org Subject: Re: rs/6000 e30 + 240 (doral) support Message-ID: <20040729151813.GB13987@pegasos> References: <9ef20ef304071613494a0f0af9@mail.gmail.com> <20040717014441.GA13447@pegasos> <20040729135130.GE19197@lst.de> <9ef20ef3040729070439f6d8c1@mail.gmail.com> <20040729141631.GA20149@lst.de> <9ef20ef304072907243f820e04@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: <9ef20ef304072907243f820e04@mail.gmail.com> From: Sven Luther Sender: owner-linuxppc-dev@lists.linuxppc.org List-Id: On Thu, Jul 29, 2004 at 11:24:35AM -0300, Gustavo Barbieri wrote: > On Thu, 29 Jul 2004 16:16:31 +0200, Christoph Hellwig wrote: > > On Thu, Jul 29, 2004 at 11:04:48AM -0300, Gustavo Barbieri wrote: > > > > Most doesn't look too bad to me, but it's a lot of patches. I vaguely > > > > remember they were discussed on linuxppc-dev, so we should check the > > > > comments over there. > > > > > > A lot of patches? Well, there is a lot of "code"... it's not really > > > code, but just structure definitions... actually the patche touches > > > the real code at few points, one it's just a null pointer checking, > > > other are added cases to the switch statement so it can handle those > > > boards, so I really can't a problem there. > > > > > > I already sent an email to linuxppc-dev in the past, but no replies: > > > > > > http://lists.linuxppc.org/linuxppc-dev/200407/msg00085.html > > > > Ah sorry, I confused it with Len's big IBM prep patchkit. Except for a > > tiny style issue this patch is fine with me. > > What style issue? > > > > Any upstream comments as I'd hate to carry along a patch like that in > > the Debian patchkit while we'd probably want it in Sarge. > > > > Gustavo, if we apply this patch you'll have to sign up for d-i testing > > on prep, though ;-) > > Ok, I test... actually I'm using sarge on that machine. > > But I need to test it soon, as this machine may go away in few weeks. Well, since sarge d-i will probably be released before you lose that machine, it should be no problem. We first need to rebuild a kernel though. Christoph, do this and other patches warrant a kernel-source 2.6.7-4 upload, or is it better to keep it in the powerpc patches for now ? Friendly; Sven Luther ** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/