Re: [PATCH] Isolated sched domains for 2.6.8-rc2-mm1

[Andrew Morton <akpm@osdl.org>]

Dimitri Sivanich <sivanich@sgi.com> wrote:
>
> Here's a version of the isolated scheduler domain code that I mentioned in an
>  RFC on 7/22.  This patch applies on top of 2.6.8-rc2-mm1 (to include all of
>  the new arch_init_sched_domain code).  This patch also contains the 2 line
>  fix to remove the check of first_cpu(sd->groups->cpumask)) that Jesse
>  sent in earlier.
> 
>  Note that this has not been tested with CONFIG_SCHED_SMT.  I hope that
>  my handling of those instances is OK.

It wasn't even compile-tested :(

diff -puN kernel/sched.c~sched-isolated-sched-domains-fix kernel/sched.c
--- 25/kernel/sched.c~sched-isolated-sched-domains-fix	2004-07-31 18:00:24.258057576 -0700
+++ 25-akpm/kernel/sched.c	2004-07-31 18:00:45.420840344 -0700
@@ -3861,7 +3861,7 @@ __init static void arch_init_sched_domai
 		if (i != first_cpu(this_sibling_map))
 			continue;
 
-		init_sched_build_groups(sched_group_cpus, this_sibling_mask,
+		init_sched_build_groups(sched_group_cpus, this_sibling_map,
 						&cpu_to_cpu_group);
 	}
 #endif
_