All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-arch@vger.kernel.org
Subject: Re: find_next_bit return type
Date: Sun, 1 Aug 2004 00:10:26 -0700	[thread overview]
Message-ID: <20040801001026.68ed7363.davem@redhat.com> (raw)
In-Reply-To: <20040801000213.5f01b469.akpm@osdl.org>

On Sun, 1 Aug 2004 00:02:13 -0700
Andrew Morton <akpm@osdl.org> wrote:

> Kind-of.  But it's also cringeworthy to go slinging 8-byte values around
> when 4-byte values would suffice.  Is it not more efficient to use
> integers?

They all go in registers, the same register that could hold the 4-byte
values too.  There is also no computational cost to doing 64-bit add
subtract and shift (ie. simple ALU's) compared to 32-bit ones.

The int return value is also evil on many 64-bit systems because
it's going to do all of the computations in the native largest natural
word size (64-bits) then chop it down and sign extent it to 'int' (32-bits)

On 32-bitters none of this prototype crap will matter, since both int
and long are 32-bit of course.

I'm not %100 against using unsigned int, it's just that I know it will
crap up the output code a bit for 64-bitters.

  reply	other threads:[~2004-08-01  7:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-01  6:24 find_next_bit return type Andrew Morton
2004-08-01  6:25 ` Andrew Morton
2004-08-01  6:58   ` David S. Miller
2004-08-01  7:02     ` Andrew Morton
2004-08-01  7:10       ` David S. Miller [this message]
2004-08-02 10:40         ` Andi Kleen
2004-08-01  6:25 ` Andrew Morton
2004-08-01  6:26 ` Andrew Morton
2004-08-01 11:53 ` William Lee Irwin III
2004-08-01 13:51   ` William Lee Irwin III
2004-08-01 15:05 ` James Bottomley
2004-08-01 15:07   ` William Lee Irwin III
2004-08-01 22:09   ` Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040801001026.68ed7363.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=akpm@osdl.org \
    --cc=linux-arch@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.