From: Suparna Bhattacharya <suparna@in.ibm.com>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] mpage writepages range limit fix
Date: Sun, 1 Aug 2004 13:20:52 +0530 [thread overview]
Message-ID: <20040801075052.GC7327@in.ibm.com> (raw)
In-Reply-To: <20040801074518.GA7310@in.ibm.com>
On Sun, Aug 01, 2004 at 01:15:18PM +0530, Suparna Bhattacharya wrote:
>
> The attached patches (generated against 2.6.8-rc2) enable concurrent
> O_SYNC writers to different parts of the same file by avoiding
> serialising on i_sem across the wait for IO completion.
>
> This is mostly your work, ported to the tagged radix tree VFS changes
> and a few fixes. I have been carrying these patches for sometime now;
> they can be the merged upstream. Please apply.
>
[3] fix-writepages-range.patch
Regards
Suparna
--
Suparna Bhattacharya (suparna@in.ibm.com)
Linux Technology Center
IBM Software Lab, India
---------------------------------------------------------------
Safeguard to make sure we break out of pagevec_lookup_tag loop if we
are beyond the specified range.
Signed-off-by: Suparna Bhattacharya <suparna@in.ibm.com>
linux-2.6.8-rc2-suparna/fs/mpage.c | 3 ++-
linux-2.6.8-rc2-suparna/fs/mpage.c.orig | 3 +--
2 files changed, 3 insertions(+), 3 deletions(-)
diff -puN fs/mpage.c~fix-writepages-range fs/mpage.c
--- linux-2.6.8-rc2/fs/mpage.c~fix-writepages-range 2004-08-01 12:33:10.000000000 +0530
+++ linux-2.6.8-rc2-suparna/fs/mpage.c 2004-08-01 12:33:10.000000000 +0530
@@ -649,7 +649,8 @@ mpage_writepages(struct address_space *m
scanned = 1;
}
retry:
- while (!done && (nr_pages = pagevec_lookup_tag(&pvec, mapping, &index,
+ while (!done && (index <= end) &&
+ (nr_pages = pagevec_lookup_tag(&pvec, mapping, &index,
PAGECACHE_TAG_DIRTY,
min(end - index, (pgoff_t)PAGEVEC_SIZE-1) + 1))) {
unsigned i;
diff -puN fs/mpage.c.orig~fix-writepages-range fs/mpage.c.orig
--- linux-2.6.8-rc2/fs/mpage.c.orig~fix-writepages-range 2004-08-01 12:33:10.000000000 +0530
+++ linux-2.6.8-rc2-suparna/fs/mpage.c.orig 2004-08-01 12:32:43.000000000 +0530
@@ -649,8 +649,7 @@ mpage_writepages(struct address_space *m
scanned = 1;
}
retry:
- while (!done && (index <= end) &&
- (nr_pages = pagevec_lookup_tag(&pvec, mapping, &index,
+ while (!done && (nr_pages = pagevec_lookup_tag(&pvec, mapping, &index,
PAGECACHE_TAG_DIRTY,
min(end - index, (pgoff_t)PAGEVEC_SIZE-1) + 1))) {
unsigned i;
_
next prev parent reply other threads:[~2004-08-01 7:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-01 7:45 [PATCH 0/5] Concurrent O_SYNC write speedups using radix-tree walks Suparna Bhattacharya
2004-08-01 7:47 ` [PATCH 1/5] Writeback page range hint Suparna Bhattacharya
2004-08-01 7:49 ` [PATCH 2/5] Fix writeback page range to use exact limits Suparna Bhattacharya
2004-08-01 7:50 ` Suparna Bhattacharya [this message]
2004-08-01 7:52 ` [PATCH 4/5] filemap_fdatawrite range interface Suparna Bhattacharya
2004-08-01 7:53 ` [PATCH 5/5] Concurrent O_SYNC write support Suparna Bhattacharya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040801075052.GC7327@in.ibm.com \
--to=suparna@in.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.