All of lore.kernel.org
 help / color / mirror / Atom feed
From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] Re: linux2.6.7: af_ipx.c init cleanup
Date: Sun, 01 Aug 2004 22:20:46 +0000	[thread overview]
Message-ID: <20040801222046.GB2276@masina.coderock.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1610 bytes --]

On 01/08/04 21:41 +0200, Walter Harms wrote:
> Hi list,
> i moved the messages directly into the code also.
>

Someone's gonna be happy with all the error messages, when he hits this :-)
(also... you can do better than numbered labels)
> +       err=ipx_proc_init();
> +       if (err < 0)
> +               goto exit_7;
> +#endif
>         return 0;
> +exit_7:
> +       ipx_unregister_sysctl();
> +
> +exit_6:
> +       unregister_snap_client(pSNAP_datalink);
> +exit_5:
> +       printk(KERN_CRIT "IPX: Unable to register with SNAP\n");
> +       unregister_8022_client(p8022_datalink);
> +exit_4:
> +       printk(KERN_CRIT "IPX: Unable to register with 802.2\n");
> +       dev_remove_pack(&ipx_8023_packet_type);
> +       destroy_8023_client(p8023_datalink);
> +exit_3:
> +       printk(KERN_CRIT "IPX: Unable to register with 802.3\n");
> +       dev_remove_pack(&ipx_dix_packet_type);
> +       destroy_EII_client(pEII_datalink);
> +exit_2:
> +       printk(KERN_CRIT "IPX: Unable to register with Ethernet II\n");
> +       sock_unregister(ipx_family_ops.family);
> +exit_1:
> +       return -1;
> +
>  }
>  
>  static void __exit ipx_proto_finito(void)
>  {
> +#ifdef CONFIG_PROC_FS
>         ipx_proc_exit();
> -       ipx_unregister_sysctl();
> +#endif
>  
> +#ifdef CONFIG_SYSCTL
> +       ipx_unregister_sysctl();
> +#endif
>         unregister_netdevice_notifier(&ipx_dev_notifier);
>  
>         ipxitf_cleanup();
> 
> 

> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.osdl.org
> http://lists.osdl.org/mailman/listinfo/kernel-janitors


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

                 reply	other threads:[~2004-08-01 22:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040801222046.GB2276@masina.coderock.org \
    --to=domen@coderock.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.