From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Jones Subject: Re: my dothan didn't work with cpufreq... Date: Mon, 2 Aug 2004 20:26:08 +0100 Sender: cpufreq-bounces@www.linux.org.uk Message-ID: <20040802192608.GA17023@redhat.com> References: <40F2FA8B.10307@lifl.fr> <20040713094937.GB8124@dominikbrodowski.de> <1090461320.13505.3.camel@localhost> <20040722060437.GA8888@dominikbrodowski.de> <1090479407.4351.6.camel@localhost> <20040722093126.GA8418@dominikbrodowski.de> <1090517665.5267.9.camel@ixodes.goop.org> <20040723193859.GC8441@dominikbrodowski.de> <1090632444.2950.1.camel@localhost> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <1090632444.2950.1.camel@localhost> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: cpufreq-bounces+glkc-cpufreq=gmane.org@www.linux.org.uk Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jeremy Fitzhardinge Cc: Dominik Brodowski , cpufreq list On Fri, Jul 23, 2004 at 06:27:24PM -0700, Jeremy Fitzhardinge wrote: > On Fri, 2004-07-23 at 21:38 +0200, Dominik Brodowski wrote: > > Again IIRC, it's less about CodingStyle and more about some GCC 3.? > > warnings? Though, gcc 3.3.4 doesn't complain... > > You mean the "[idx] = " syntax? > > Anyway, having said that, I got it wrong (I had vendor and family > switched). Fixed patch attached. I merged this, but something occurred to me whilst eyeballing the diffs. Rather than duplicating X86_VENDOR_INTEL in every entry of the struct, how about we check it in one place? I'm unaware of any vendor planning to duplicate speedstep, but even if AMD/VIA threw away their current implementations in favour of a bit-for-bit compatible implementation, it wouldn't be hard to add an extra if() comments? Dave