Re: #263154: iptables: segfault with multiple ip hostnames

[Phil Oester <kernel@linuxace.com>]

On Tue, Aug 03, 2004 at 06:03:50PM -0400, Laurence J. Lane wrote:
> http://bugs.debian.org/263154
> 
> iptables 1.2.11 segfaults when given a domain name that resolves 
> to multiple ip addresses. The situation is the same for kernel 
> versions 2.4.26 and 2.6.7.

This is fixed in CVS.  Patch below for reference.

Phil


diff -u -r1.68 -r1.69
--- iptables/iptables.c	2004/05/26 16:04:48	1.68
+++ iptables/iptables.c	2004/07/04 15:20:53	1.69
@@ -2339,11 +2339,8 @@
 		e = NULL;
 	}
 
-	for (c = 0; c < nsaddrs; c++)
-		free(&saddrs[c]);
-
-	for (c = 0; c < ndaddrs; c++)
-		free(&daddrs[c]);
+	free(saddrs);
+	free(daddrs);
 
 	if (opts != original_opts) {
 		free(opts);