From: Jens Axboe <axboe@suse.de>
To: Pat LaVarre <p.lavarre@ieee.org>
Cc: linux-scsi@vger.kernel.org,
Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
John McKell <McKellj@iomega.com>
Subject: Re: [PATCH] DVD-RAM rewritable again
Date: Wed, 4 Aug 2004 06:58:42 +0200 [thread overview]
Message-ID: <20040804045839.GA8139@suse.de> (raw)
In-Reply-To: <1091568097.3644.27.camel@patibmrh9>
On Tue, Aug 03 2004, Pat LaVarre wrote:
> Jens A:
>
> Can I help by offering the trivial patch shown here? Or can I help in
> some other way?
>
> I ask because I see this patch makes my PATAPI DVD-RAM disc as
> rewritable as it was in 2.4.26.
>
> Per my understanding of your instructions, I defer, until 2.4.28, the
> non-trivial work of making PATAPI and USB DVD-RAM discs behave the same.
>
> Per my understanding of your instructions, I leave USB DVD-RAM discs not
> rewritable until 2.4.28, since those discs have not been rewritable at
> least since 2.4.26.
>
> Pat LaVarre
>
> diff -urp linux-2.4.27-rc4/drivers/cdrom/cdrom.c linux-2.4.27-rc4-pel/drivers/cdrom/cdrom.c
> --- linux-2.4.27-rc4/drivers/cdrom/cdrom.c 2004-08-01 08:50:45.000000000 -0600
> +++ linux-2.4.27-rc4-pel/drivers/cdrom/cdrom.c 2004-08-03 15:10:48.048576912 -0600
> @@ -536,6 +536,8 @@ static int cdrom_open_write(struct cdrom
> if (CDROM_CAN(CDC_RAM) &&
> !CDROM_CAN(CDC_CD_R|CDC_CD_RW|CDC_DVD|CDC_DVD_R))
> ret = cdrom_ram_open_write(cdi);
> + else if (CDROM_CAN(CDC_DVD_RAM))
> + ret = 0;
> else
> ret = 1;
That looks fine!
--
Jens Axboe
next prev parent reply other threads:[~2004-08-04 4:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-03 21:21 [PATCH] DVD-RAM rewritable again Pat LaVarre
2004-08-04 4:58 ` Jens Axboe [this message]
2004-08-04 11:35 ` Pat LaVarre
2004-08-04 11:38 ` Jens Axboe
2004-08-17 15:19 ` dvd-ram open succeeds despite write-protect Pat LaVarre
2004-08-04 11:57 ` [PATCH] DVD-RAM rewritable again Marcelo Tosatti
2004-08-20 22:40 ` Pat LaVarre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040804045839.GA8139@suse.de \
--to=axboe@suse.de \
--cc=McKellj@iomega.com \
--cc=linux-scsi@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=p.lavarre@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.