From: "David S. Miller" <davem@redhat.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: greearb@candelatech.com, netdev@oss.sgi.com
Subject: Re: [PATCH 2.6] (1/3) add ethtool ioctl forwarding to vlan
Date: Wed, 4 Aug 2004 09:56:40 -0700 [thread overview]
Message-ID: <20040804095640.20fd1822.davem@redhat.com> (raw)
In-Reply-To: <20040803105017.0774e1db@dell_ss3.pdx.osdl.net>
On Tue, 3 Aug 2004 10:50:17 -0700
Stephen Hemminger <shemminger@osdl.org> wrote:
> When network devices are used in bridges, the bridge does an ethtool
> ioctl to pick up the speed; this doesn't work with vlans.
> This patch makes any ethtool gets forwarded to the under lying
> real device. It seemed to make sense to do MII as well.
By changing the ifr.ifr_name field, you are going to corrupt
the return value the user will see if ':' "colon" processing
is done by dev_ioctl().
An ifreq isn't too large, just use a local copy on
vlan_dev_ioctl()'s stack.
prev parent reply other threads:[~2004-08-04 16:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-03 17:50 [PATCH 2.6] (1/3) add ethtool ioctl forwarding to vlan Stephen Hemminger
2004-08-03 18:02 ` Ben Greear
2004-08-03 20:40 ` [PATCH 2.6] (2/3) vlan propogate carrier and hotplug state Stephen Hemminger
2004-08-03 20:53 ` Ben Greear
2004-08-09 23:46 ` David S. Miller
2004-08-03 20:43 ` [PATCH 2.6] (3/3) vlan - use RCU Stephen Hemminger
2004-08-03 21:03 ` Ben Greear
2004-08-09 23:48 ` David S. Miller
2004-08-04 16:56 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040804095640.20fd1822.davem@redhat.com \
--to=davem@redhat.com \
--cc=greearb@candelatech.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.