From: Bernd Schubert <bernd-schubert@web.de>
To: Hugh Dickins <hugh@veritas.com>
Cc: Andrew Morton <akpm@osdl.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
Frank.Otto@tc.pci.uni-heidelberg.de
Subject: Re: [2.6.8-rc2-mm2] oops report (crashes on booting)
Date: Wed, 4 Aug 2004 21:53:36 +0200 [thread overview]
Message-ID: <200408042153.38404.bernd-schubert@web.de> (raw)
In-Reply-To: <Pine.LNX.4.44.0408041808050.30401-100000@localhost.localdomain>
>
> tmpfs must use __copy_from_user_inatomic now, to avoid might_sleep
> warning, when knowingly using __copy_from_user with an atomic kmap.
>
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
>
> --- 2.6.8-rc2-mm2/mm/shmem.c 2004-08-02 13:03:33.000000000 +0100
> +++ linux/mm/shmem.c 2004-08-04 18:05:07.917110256 +0100
> @@ -1323,7 +1323,8 @@ shmem_file_write(struct file *file, cons
> __get_user(dummy, buf + bytes - 1);
>
> kaddr = kmap_atomic(page, KM_USER0);
> - left = __copy_from_user(kaddr + offset, buf, bytes);
> + left = __copy_from_user_inatomic(kaddr + offset,
> + buf, bytes);
> kunmap_atomic(kaddr, KM_USER0);
> }
> if (left) {
Thanks a lot, that fixed it.
Bernd
prev parent reply other threads:[~2004-08-04 19:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-04 16:28 [2.6.8-rc2-mm2] oops report (crashes on booting) Bernd Schubert
2004-08-04 17:20 ` Hugh Dickins
2004-08-04 19:53 ` Bernd Schubert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200408042153.38404.bernd-schubert@web.de \
--to=bernd-schubert@web.de \
--cc=Frank.Otto@tc.pci.uni-heidelberg.de \
--cc=akpm@osdl.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.