From: "Paweł Sikora" <pluto@pld-linux.org>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: linux-kernel@vger.kernel.org, spot@redhat.com, akpm@osdl.org
Subject: Re: Make MAX_INIT_ARGS 25
Date: Thu, 5 Aug 2004 07:52:46 +0200 [thread overview]
Message-ID: <200408050752.46409.pluto@pld-linux.org> (raw)
In-Reply-To: <20040804193243.36009baa@lembas.zaitcev.lan>
[-- Attachment #1: Type: text/plain, Size: 553 bytes --]
On Thursday 05 of August 2004 04:32, Pete Zaitcev wrote:
> --- linux-2.6.7/init/main.c 2004-06-16 16:54:07.000000000 -0700
> +++ linux-2.6.7-usb/init/main.c 2004-08-04 19:16:22.566593218 -0700
> @@ -102,8 +102,8 @@
> /*
> * Boot command-line arguments
> */
> -#define MAX_INIT_ARGS 8
> -#define MAX_INIT_ENVS 8
> +#define MAX_INIT_ARGS 25
> +#define MAX_INIT_ENVS 25
You should also increase the COMMAND_LINE_SIZE.
--
/* Copyright (C) 2003, SCO, Inc. This is valuable Intellectual Property. */
#define say(x) lie(x)
[-- Attachment #2: kernel-MAX_INIT_ARGS.patch --]
[-- Type: text/x-diff, Size: 2485 bytes --]
--- linux-2.6.7-rc2/init/main.c.org 2004-06-04 12:58:31.000000000 +0200
+++ linux-2.6.7-rc2/init/main.c 2004-06-04 13:43:02.000000000 +0200
@@ -103,8 +103,8 @@
/*
* Boot command-line arguments
*/
-#define MAX_INIT_ARGS 8
-#define MAX_INIT_ENVS 8
+#define MAX_INIT_ARGS 256
+#define MAX_INIT_ENVS 256
extern void time_init(void);
/* Default late time init is NULL. archs can override this later. */
--- linux-2.6.7/include/asm-i386/param.h.orig 2004-07-03 16:56:41.000000000 +0200
+++ linux-2.6.7/include/asm-i386/param.h 2004-07-03 19:10:53.358244832 +0200
@@ -18,6 +18,6 @@
#endif
#define MAXHOSTNAMELEN 64 /* max length of hostname */
-#define COMMAND_LINE_SIZE 256
+#define COMMAND_LINE_SIZE 4096
#endif
diff -Nur --exclude '*.orig' linux-2.6.7-rc3.org/include/asm-i386/setup.h linux-2.6.7-rc3/include/asm-i386/setup.h
--- linux-2.6.7-rc3.org/include/asm-i386/setup.h 2004-06-07 21:14:42.000000000 +0200
+++ linux-2.6.7-rc3/include/asm-i386/setup.h 2004-06-08 11:29:19.000000000 +0200
@@ -17,7 +17,7 @@
#define MAX_NONPAE_PFN (1 << 20)
#define PARAM_SIZE 2048
-#define COMMAND_LINE_SIZE 256
+#define COMMAND_LINE_SIZE 4096
#define OLD_CL_MAGIC_ADDR 0x90020
#define OLD_CL_MAGIC 0xA33F
diff -Nur --exclude '*.orig' linux-2.6.7-rc3.org/include/asm-s390/setup.h linux-2.6.7-rc3/include/asm-s390/setup.h
--- linux-2.6.7-rc3.org/include/asm-s390/setup.h 2004-06-07 21:14:58.000000000 +0200
+++ linux-2.6.7-rc3/include/asm-s390/setup.h 2004-06-08 11:30:38.000000000 +0200
@@ -9,7 +9,7 @@
#define _ASM_S390_SETUP_H
#define PARMAREA 0x10400
-#define COMMAND_LINE_SIZE 896
+#define COMMAND_LINE_SIZE 4096
#define RAMDISK_ORIGIN 0x800000
#define RAMDISK_SIZE 0x800000
--- linux-2.6.7/include/asm-ppc/setup.h.orig 2004-07-06 17:53:17.000000000 +0200
+++ linux-2.6.7/include/asm-ppc/setup.h 2004-07-06 17:55:37.428864888 +0200
@@ -8,7 +8,7 @@
#include <asm-m68k/setup.h>
/* We have a bigger command line buffer. */
#undef COMMAND_LINE_SIZE
-#define COMMAND_LINE_SIZE 512
+#define COMMAND_LINE_SIZE 4096
#endif /* _PPC_SETUP_H */
#endif /* __KERNEL__ */
--- linux-2.6.7/arch/ppc/syslib/prom.c.orig 2004-07-06 17:53:30.000000000 +0200
+++ linux-2.6.7/arch/ppc/syslib/prom.c 2004-07-06 17:55:57.781770776 +0200
@@ -85,7 +85,7 @@
extern void enter_rtas(void *);
void phys_call_rtas(int, int, int, ...);
-extern char cmd_line[512]; /* XXX */
+extern char cmd_line[COMMAND_LINE_SIZE];
extern boot_infos_t *boot_infos;
unsigned long dev_tree_size;
next prev parent reply other threads:[~2004-08-05 5:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-05 2:32 Make MAX_INIT_ARGS 25 Pete Zaitcev
2004-08-05 5:52 ` Paweł Sikora [this message]
2004-08-05 15:21 ` Pete Zaitcev
2004-08-05 16:13 ` Paul Jackson
2004-08-05 14:39 ` Olaf Hering
2004-08-05 16:08 ` Paul Jackson
2004-08-05 16:12 ` Olaf Hering
2004-08-06 20:10 ` Pete Zaitcev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200408050752.46409.pluto@pld-linux.org \
--to=pluto@pld-linux.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=spot@redhat.com \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.