All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell Coker <rcoker@redhat.com>
To: Colin Walters <walters@redhat.com>
Cc: dwalsh@redhat.com, selinux@tycho.nsa.gov
Subject: Re: [patch] fix /var/run/console bits
Date: Thu, 5 Aug 2004 17:40:14 +1000	[thread overview]
Message-ID: <200408051740.14931.rcoker@redhat.com> (raw)
In-Reply-To: <1091624615.9005.6.camel@nexus.verbum.private>

On Wed, 4 Aug 2004 23:03, Colin Walters <walters@redhat.com> wrote:
> > I think that perhaps the following would be good for the fc entry to keep
> > the convention:
> > /var/run/console/(.*)?                    
> > system_u:object_r:pam_var_console_t
>
> Sounds good.

Actually I did a typo, this is what is should be:
/var/run/console(/.*)?    system_u:object_r:pam_var_console_t

> > This is not what we want.  Ideally we will never have any files of type
> > var_run_t.
> > rw_dir_create_file(xdm_t, var_run_t)
> > rw_dir_create_file($1_login_t, var_run_t)
>
> I agree, but unfortunately pam_console creates a lockfile
> named /var/run/console.lock.  We should probably fix that.

Dan has just offered to fix that.  But if it was not possible to change that 
then the solution would be to have a file_type_auto_trans() rule.

I've been thinking of adding neverallow rules to prevent any access to files 
of type var_run_t, tmp_t, and tmpfs_t...

> > I guess that the following code is to allow the xdm to check which login
> > processes are active when searching for an unused virtual console.
>
> Ok.  I just thought it was weird at first glance, and worthy of a
> comment :)

It is weird, and probably something needs to be changed about it.

-- 
http://apac.redhat.com/disclaimer
See above URL for disclaimer.

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

  parent reply	other threads:[~2004-08-05  7:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-04  2:01 [patch] fix /var/run/console bits Colin Walters
2004-08-04  9:30 ` Luke Kenneth Casson Leighton
2004-08-04 10:07 ` Russell Coker
2004-08-04 13:03   ` Colin Walters
2004-08-04 13:19     ` Daniel J Walsh
2004-08-05  7:40     ` Russell Coker [this message]
2004-08-05 19:23       ` Stephen Smalley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200408051740.14931.rcoker@redhat.com \
    --to=rcoker@redhat.com \
    --cc=dwalsh@redhat.com \
    --cc=selinux@tycho.nsa.gov \
    --cc=walters@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.