From: Arnd Bergmann <arnd@arndb.de>
To: Alessandro Amici <alexamici@fastwebnet.it>
Cc: linux-kernel@vger.kernel.org, linux-390@vm.marist.edu,
arjanv@redhat.com, tim.bird@am.sony.com, mulix@mulix.org,
alan@redhat.com, jan.glauber@de.ibm.com
Subject: Re: [PATCH] cputime (1/6): move call to update_process_times.
Date: Thu, 5 Aug 2004 22:54:20 +0200 [thread overview]
Message-ID: <200408052254.20715.arnd@arndb.de> (raw)
In-Reply-To: <200408052157.47603.alexamici@fastwebnet.it>
[-- Attachment #1: Type: text/plain, Size: 667 bytes --]
On Donnerstag, 5. August 2004 21:57, Alessandro Amici wrote:
> I don't have enough knowledge to comment on the merit of the move to
> architecture files, but the proliferation of #ifndef CONFIG_SMP looks really
> ugly.
Yes, it does.
> Wouldn't it be possible to move the #ifndef into sched.h?
You can't simply define it to a nop in case of SMP, because
there it is called from a different place, but we could
have a separate version for UP and SMP in sched.h:
void update_process_times(int user_tick);
static inline void update_process_times_nonsmp(int user_tick)
{
#ifndef CONFIG_SMP
update_process_times(user_tick);
#endif
}
Arnd <><
[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-08-05 20:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-05 18:03 [PATCH] cputime (1/6): move call to update_process_times Martin Schwidefsky
2004-08-05 19:57 ` Alessandro Amici
2004-08-05 20:54 ` Arnd Bergmann [this message]
2004-08-05 21:54 ` Alessandro Amici
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200408052254.20715.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=alan@redhat.com \
--cc=alexamici@fastwebnet.it \
--cc=arjanv@redhat.com \
--cc=jan.glauber@de.ibm.com \
--cc=linux-390@vm.marist.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=mulix@mulix.org \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.