From: Andrew Morton <akpm@osdl.org>
To: Phillip Lougher <phillip@lougher.demon.co.uk>
Cc: nickpiggin@yahoo.com.au, linux-kernel@vger.kernel.org,
viro@parcelfarce.linux.theplanet.co.uk
Subject: Re: [PATCH] VFS readahead bug in 2.6.8-rc[1-3]
Date: Fri, 6 Aug 2004 12:46:09 -0700 [thread overview]
Message-ID: <20040806124609.3d489a0d.akpm@osdl.org> (raw)
In-Reply-To: <4113D977.9040105@lougher.demon.co.uk>
Phillip Lougher <phillip@lougher.demon.co.uk> wrote:
>
> Nick Piggin wrote:
>
> > No, I suggest you start to code assuming this interface does
> > what it does. I didn't say there is no bug here, but nobody
> > else's filesystem breaks.
> >
>
> To stop this silly argument from escalating, I will patch my code.
>
Well I don't think it's silly.
We are deterministically asking the fs to read a page which lies outside
EOF, and we shouldn't. If for no other reason than that the ever-popular
"read a million 4k files" workload will consume extra CPU and twice the
pagecache.
next prev parent reply other threads:[~2004-08-06 19:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-05 17:50 [PATCH] VFS readahead bug in 2.6.8-rc[1-3] Phillip Lougher
2004-08-06 0:55 ` Nick Piggin
2004-08-06 2:19 ` Nick Piggin
2004-08-06 16:58 ` Phillip Lougher
2004-08-06 18:58 ` Nick Piggin
2004-08-06 19:14 ` Phillip Lougher
2004-08-06 19:31 ` viro
2004-08-06 19:18 ` Phillip Lougher
2004-08-06 19:46 ` Andrew Morton [this message]
2004-08-16 7:55 ` [PATCH] " Ram Pai
2004-08-07 14:21 ` Pozsar Balazs
[not found] <Pine.LNX.4.44.0408052104420.2241-100000@dyn319181.beaverton.ibm.com>
[not found] ` <411322E8.4000503@yahoo.com.au>
2004-08-06 10:47 ` Ram
2004-08-06 17:05 ` Phillip Lougher
2004-08-06 18:02 ` Ram Pai
2004-08-06 19:09 ` Nick Piggin
2004-08-06 19:39 ` Phillip Lougher
2004-08-06 20:21 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040806124609.3d489a0d.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=phillip@lougher.demon.co.uk \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.