Re: warning: comparison is always false due to limited range of data type

[Andi Kleen <ak@muc.de>]

On Sat, Aug 07, 2004 at 05:41:33PM -0700, Paul Jackson wrote:
> david+challenge-response@blue-labs.org wrote:
> > fs/smbfs/inode.c:563: warning: comparison is always false due to limited 
> > range of data type
> > fs/smbfs/inode.c:564: warning: comparison is always false due to limited 
> > range of data type
> 
> You're lucky you're still on the cc list David - please don't use reply
> addresses that require editing.
> 
> Adding Andi Kleen <ak@muc.de> to cc list - looks from the bk log that he
> might have some interest in this.

Sorry, I forgot what I changed here. At least my original
changes didn't cause warnings as far as I know. Someone else please
take care of it.

-Andi

> 
> fs/smbfs/inode.c
>   1.46 03/12/01 07:04:55 ak@muc.de[torvalds] +2 -2
>   UID16 fixes
> 
> bk diffs -r1.45..1.46 fs/smbfs/inode.c
> ===== fs/smbfs/inode.c 1.45 vs 1.46 =====
> 554,555c554,555
> <               mnt->uid = OLD_TO_NEW_UID(oldmnt->uid);
> <               mnt->gid = OLD_TO_NEW_GID(oldmnt->gid);
> ---
> >               SET_UID(mnt->uid, oldmnt->uid);
> >               SET_GID(mnt->gid, oldmnt->gid);
> 
> -- 
>                           I won't rest till it's the best ...
>                           Programmer, Linux Scalability
>                           Paul Jackson <pj@sgi.com> 1.650.933.1373