From: Adrian Bunk <bunk@fs.tum.de>
To: linux-kernel@vger.kernel.org
Subject: [2.6 patch] select FW_LOADER -> depends HOTPLUG
Date: Mon, 9 Aug 2004 21:56:56 +0200 [thread overview]
Message-ID: <20040809195656.GX26174@fs.tum.de> (raw)
The contract is easy:
If you select something, you have to ensure the depenencies of the
selected option are met.
This is simple.
And most people get it wrong.
The patch below adds dependencies on HOTPLUG for all options that select
FW_LOADER.
diffstat output:
drivers/bluetooth/Kconfig | 4 ++--
drivers/media/dvb/ttpci/Kconfig | 2 +-
drivers/media/dvb/ttusb-dec/Kconfig | 2 +-
drivers/net/wireless/Kconfig | 5 ++---
drivers/scsi/Kconfig | 2 +-
5 files changed, 7 insertions(+), 8 deletions(-)
Signed-off-by: Adrian Bunk <bunk@fs.tum.de>
--- linux-2.6.8-rc3-mm2-full-3.4/drivers/bluetooth/Kconfig.old 2004-08-09 21:48:55.000000000 +0200
+++ linux-2.6.8-rc3-mm2-full-3.4/drivers/bluetooth/Kconfig 2004-08-09 21:49:18.000000000 +0200
@@ -65,7 +65,7 @@
config BT_HCIBCM203X
tristate "HCI BCM203x USB driver"
- depends on USB
+ depends on USB && HOTPLUG
select FW_LOADER
help
Bluetooth HCI BCM203x USB driver.
@@ -77,7 +77,7 @@
config BT_HCIBFUSB
tristate "HCI BlueFRITZ! USB driver"
- depends on USB
+ depends on USB && HOTPLUG
select FW_LOADER
help
Bluetooth HCI BlueFRITZ! USB driver.
--- linux-2.6.8-rc3-mm2-full-3.4/drivers/scsi/Kconfig.old 2004-08-09 21:48:20.000000000 +0200
+++ linux-2.6.8-rc3-mm2-full-3.4/drivers/scsi/Kconfig 2004-08-09 21:48:32.000000000 +0200
@@ -1019,7 +1019,7 @@
config SCSI_IPR
tristate "IBM Power Linux RAID adapter support"
- depends on PCI && SCSI && PPC
+ depends on PCI && SCSI && PPC && HOTPLUG
select FW_LOADER
---help---
This driver supports the IBM Power Linux family RAID adapters.
--- linux-2.6.8-rc3-mm2-full-3.4/drivers/media/dvb/ttusb-dec/Kconfig.old 2004-08-09 21:47:21.000000000 +0200
+++ linux-2.6.8-rc3-mm2-full-3.4/drivers/media/dvb/ttusb-dec/Kconfig 2004-08-09 21:47:52.000000000 +0200
@@ -1,6 +1,6 @@
config DVB_TTUSB_DEC
tristate "Technotrend/Hauppauge USB DEC devices"
- depends on DVB_CORE && USB
+ depends on DVB_CORE && USB && HOTPLUG
select FW_LOADER
select CRC32
help
--- linux-2.6.8-rc3-mm2-full-3.4/drivers/media/dvb/ttpci/Kconfig.old 2004-08-09 21:45:32.000000000 +0200
+++ linux-2.6.8-rc3-mm2-full-3.4/drivers/media/dvb/ttpci/Kconfig 2004-08-09 21:46:15.000000000 +0200
@@ -1,6 +1,6 @@
config DVB_AV7110
tristate "AV7110 cards"
- depends on DVB_CORE
+ depends on DVB_CORE && HOTPLUG
select FW_LOADER
select VIDEO_DEV
select VIDEO_SAA7146_VV
--- linux-2.6.8-rc3-mm2-full-3.4/drivers/net/wireless/Kconfig.old 2004-08-09 21:43:19.000000000 +0200
+++ linux-2.6.8-rc3-mm2-full-3.4/drivers/net/wireless/Kconfig 2004-08-09 21:44:10.000000000 +0200
@@ -223,7 +223,7 @@
config ATMEL
tristate "Atmel at76c50x chipset 802.11b support"
- depends on NET_RADIO && EXPERIMENTAL
+ depends on NET_RADIO && HOTPLUG && EXPERIMENTAL
select FW_LOADER
select CRC32
---help---
@@ -293,8 +293,6 @@
config PCMCIA_ATMEL
tristate "Atmel at76c502/at76c504 PCMCIA cards"
depends on NET_RADIO && ATMEL && PCMCIA
- select FW_LOADER
- select CRC32
---help---
Enable support for PCMCIA cards containing the
Atmel at76c502 and at76c504 chips.
@@ -309,6 +307,7 @@
comment "Prism GT/Duette 802.11(a/b/g) PCI/Cardbus support"
depends on NET_RADIO && PCI
+
config PRISM54
tristate 'Intersil Prism GT/Duette/Indigo PCI/Cardbus'
depends on PCI && NET_RADIO && EXPERIMENTAL && HOTPLUG
next reply other threads:[~2004-08-09 19:58 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-09 19:56 Adrian Bunk [this message]
2004-08-09 20:08 ` [2.6 patch] select FW_LOADER -> depends HOTPLUG Adrian Bunk
2004-08-09 20:26 ` Marcelo Tosatti
2004-08-09 22:05 ` Adrian Bunk
2004-08-09 20:38 ` Sam Ravnborg
2004-08-10 0:24 ` Roman Zippel
2004-08-10 8:44 ` Adrian Bunk
2004-08-10 21:16 ` Sam Ravnborg
2004-08-11 11:15 ` Marcelo Tosatti
2004-08-11 21:25 ` Randy.Dunlap
2004-08-11 23:05 ` Roman Zippel
2004-08-12 19:18 ` Adrian Bunk
2004-08-15 17:06 ` Roman Zippel
2004-08-14 7:49 ` menuconfig displays dependencies [Was: select FW_LOADER -> depends HOTPLUG] Sam Ravnborg
2004-08-14 18:12 ` Randy.Dunlap
2004-08-14 21:05 ` Adrian Bunk
2004-08-14 22:37 ` Sam Ravnborg
2004-08-15 20:21 ` Adrian Bunk
2004-08-15 20:32 ` Sam Ravnborg
2004-08-15 20:45 ` Adrian Bunk
2004-08-15 17:35 ` Roman Zippel
2004-08-15 17:40 ` Adrian Bunk
2004-08-15 22:47 ` Roman Zippel
2004-08-16 19:57 ` Adrian Bunk
2004-08-16 20:07 ` Russell King
2004-08-16 20:22 ` Adrian Bunk
2004-08-16 20:39 ` Roman Zippel
2004-08-15 17:28 ` Roman Zippel
2004-08-15 17:58 ` Sam Ravnborg
2004-08-15 22:49 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040809195656.GX26174@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.