From: Michael Buesch <mbuesch@freenet.de>
To: Hollis Blanchard <hollisb@us.ibm.com>
Cc: Sam Ravnborg <sam@ravnborg.org>,
linux-kernel@vger.kernel.org,
viro@parcelfarce.linux.theplanet.co.uk
Subject: Re: [RFC] Host Virtual Serial Interface driver
Date: Mon, 9 Aug 2004 21:12:22 +0200 [thread overview]
Message-ID: <200408092112.24187.mbuesch@freenet.de> (raw)
In-Reply-To: <200408091351.49211.hollisb@us.ibm.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoting Hollis Blanchard <hollisb@us.ibm.com>:
> > pr_debug is a noop if DEBUG is not defined. Make dump_hex, dump_packet
> > be a noop also and you get rid of several #ifdef in the code.
>
> I'd like to do that, but notice that dump_hex() is called from dump_packet()
> from hvsi_recv_response() (and I've just made hvsi_recv_control() the same).
> Even with debug disabled, I'd like to be able to dump a whole packet if I get
> confused...
#ifdef DEBUG
# define dump_hex_dbg(a, b) dump_hex(a, b)
#else
# define dump_hex_dbg(a, b) do { } while (0)
#endif /* DEBUG */
- --
Regards Michael Buesch [ http://www.tuxsoft.de.vu ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
iD8DBQFBF8yWFGK1OIvVOP4RAv3xAJ91heLG1BQzB+rLkA7w3D+3RhRdYgCg4pMI
uTJPQXzVvJppF14S71neVnI=
=zDzy
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2004-08-09 19:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-06 21:23 [RFC] Host Virtual Serial Interface driver Hollis Blanchard
2004-08-09 17:51 ` Randy.Dunlap
2004-08-09 18:46 ` Hollis Blanchard
2004-08-09 18:48 ` Sam Ravnborg
2004-08-09 18:51 ` Hollis Blanchard
2004-08-09 19:00 ` Sam Ravnborg
2004-08-09 19:08 ` Hollis Blanchard
2004-08-09 19:12 ` Michael Buesch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200408092112.24187.mbuesch@freenet.de \
--to=mbuesch@freenet.de \
--cc=hollisb@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.