From: Greg KH <greg@kroah.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] hotplug resource limitation
Date: Mon, 9 Aug 2004 17:04:28 -0700 [thread overview]
Message-ID: <20040810000428.GA7131@kroah.com> (raw)
In-Reply-To: <411770DD.5080207@suse.de>
On Mon, Aug 09, 2004 at 02:41:01PM +0200, Hannes Reinecke wrote:
> +#define DEBUG_KHELPER
> +
You should delete all of your debugging code before sending a patch out
:)
> + printk(KERN_INFO "khelper: max %d concurrent processes\n",
> + khelper_max);
Why always print out this info?
> diff -pur linux-2.6.8-rc2-mm2/lib/kobject.c linux-2.6.8-rc2-mm2.hotplug/lib/kobject.c
> --- linux-2.6.8-rc2-mm2/lib/kobject.c 2004-07-18 06:59:07.000000000 +0200
> +++ linux-2.6.8-rc2-mm2.hotplug/lib/kobject.c 2004-08-05 15:12:18.000000000 +0200
<snip> You really changed the kset_hotplug function, for no apparent
reason. Why?
thanks,
greg k-h
next prev parent reply other threads:[~2004-08-10 0:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-09 12:41 [PATCH 1/2] hotplug resource limitation Hannes Reinecke
2004-08-10 0:04 ` Greg KH [this message]
2004-08-10 0:05 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040810000428.GA7131@kroah.com \
--to=greg@kroah.com \
--cc=hare@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.