From: Pete Zaitcev <zaitcev@redhat.com>
To: David Brownell <david-b@pacbell.net>
Cc: Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
linux-kernel@vger.kernel.org, spam99@2thebatcave.com,
<km@westend.com>,
zaitcev@redhat.com
Subject: Re: uhci-hcd oops with 2.4.27/ intel D845GLVA
Date: Tue, 10 Aug 2004 22:02:49 -0700 [thread overview]
Message-ID: <20040810220249.5c4913ec@lembas.zaitcev.lan> (raw)
In-Reply-To: <200408102137.26004.david-b@pacbell.net>
On Tue, 10 Aug 2004 21:37:26 -0700
David Brownell <david-b@pacbell.net> wrote:
> > First, it fixes the oops in the scan_async.
>
> That's a NOP, ehci->async must never be null.
This is news. I received this patch FROM YOU. And I shipped it with
RHEL3 U3. And now it's a nop? What gives?! By the way, it's verified
to fix the oops when handoff fails.
> > +++ linux-2.4.21-17.EL-usb1/drivers/usb/host/ehci-hcd.c 2004-07-30 16:21:12.000000000 -0700
> > @@ -547,7 +547,8 @@
> >
> > /* root hub is shut down separately (first, when possible) */
> > spin_lock_irq (&ehci->lock);
> > - ehci_work (ehci, NULL);
> > + if (ehci->async)
> > + ehci_work (ehci, NULL);
> > spin_unlock_irq (&ehci->lock);
Please look at this:
http://www.ussg.iu.edu/hypermail/linux/kernel/0404.2/0156.html
-- Pete
P.S. Sorry to get your name wrong, David.
next prev parent reply other threads:[~2004-08-11 5:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-10 12:59 uhci-hcd oops with 2.4.27/ intel D845GLVA Kai Militzer
2004-08-10 17:10 ` Marcelo Tosatti
2004-08-10 17:10 ` Marcelo Tosatti
[not found] ` <mailman.1092163681.21436.linux-kernel2news@redhat.com>
2004-08-10 20:54 ` Pete Zaitcev
2004-08-11 4:37 ` David Brownell
2004-08-11 5:02 ` Pete Zaitcev [this message]
2004-08-11 7:16 ` David Brownell
2004-08-11 11:08 ` Nick Bartos
-- strict thread matches above, loose matches on Subject: below --
2004-08-09 12:15 Nick Bartos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040810220249.5c4913ec@lembas.zaitcev.lan \
--to=zaitcev@redhat.com \
--cc=david-b@pacbell.net \
--cc=km@westend.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=spam99@2thebatcave.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.