From: Jeff Garzik <jgarzik@pobox.com>
To: Jens Axboe <axboe@suse.de>
Cc: Linus Torvalds <torvalds@osdl.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: SG_IO and security
Date: Thu, 12 Aug 2004 14:37:13 -0400 [thread overview]
Message-ID: <20040812183713.GA29664@havoc.gtf.org> (raw)
In-Reply-To: <20040812182914.GA16953@suse.de>
On Thu, Aug 12, 2004 at 08:29:14PM +0200, Jens Axboe wrote:
> close = 1;
> ===== drivers/block/paride/pcd.c 1.38 vs edited =====
> --- 1.38/drivers/block/paride/pcd.c 2004-07-12 10:01:05 +02:00
> +++ edited/drivers/block/paride/pcd.c 2004-08-12 20:26:39 +02:00
> @@ -259,7 +259,7 @@
> unsigned cmd, unsigned long arg)
> {
> struct pcd_unit *cd = inode->i_bdev->bd_disk->private_data;
> - return cdrom_ioctl(&cd->info, inode, cmd, arg);
> + return cdrom_ioctl(&cd->info, inode, file, cmd, arg);
If you have the struct file, can't you eliminate the inode argument?
Jeff
next prev parent reply other threads:[~2004-08-12 18:37 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-12 12:17 SG_IO and security Alan Cox
2004-08-12 16:39 ` Linus Torvalds
2004-08-12 16:45 ` Linus Torvalds
2004-08-12 16:55 ` Jeff Garzik
2004-08-12 17:01 ` Jeff Garzik
2004-08-12 17:02 ` Linus Torvalds
2004-08-12 17:13 ` Jeff Garzik
2004-08-12 19:22 ` Kai Makisara
2004-08-13 19:25 ` Peter Jones
2004-08-13 19:37 ` Jeff Garzik
2004-08-14 7:22 ` Kai Makisara
2004-08-14 15:33 ` Alan Cox
2004-08-16 22:24 ` Bill Davidsen
2004-08-16 22:00 ` Bill Davidsen
2004-08-12 17:06 ` Arjan van de Ven
2004-08-12 17:35 ` Jens Axboe
2004-08-12 18:29 ` Jens Axboe
2004-08-12 18:37 ` Jeff Garzik [this message]
2004-08-12 18:43 ` Jens Axboe
2004-08-12 18:45 ` Christoph Hellwig
2004-08-12 18:48 ` Jens Axboe
2004-08-12 20:19 ` Alan Cox
2004-08-12 20:16 ` Alan Cox
2004-08-12 22:51 ` Eric Lammerts
2004-08-13 0:09 ` Linus Torvalds
2004-08-13 6:59 ` Jens Axboe
2004-08-13 7:22 ` viro
2004-08-13 7:43 ` Arjan van de Ven
2004-08-13 7:46 ` Jens Axboe
2004-08-13 19:18 ` Jeff Garzik
2004-08-13 19:37 ` Linus Torvalds
2004-08-13 19:44 ` Jeff Garzik
2004-08-13 19:49 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040812183713.GA29664@havoc.gtf.org \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.