From: maximilian attems <janitor@sternwelten.at>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Kernel-janitors] [PATCH] net/xirc2ps_cs: replace
Date: Sat, 14 Aug 2004 19:09:30 +0000 [thread overview]
Message-ID: <20040814190930.GL1756@stro.at> (raw)
In-Reply-To: <20040727183752.GS2099@us.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1697 bytes --]
On Tue, 27 Jul 2004, Nishanth Aravamudan wrote:
> I would appreciate any comments from the janitors list.
>
> Applys-to: 2.6.7
>
> Description: Replace Wait() with msleep() to guarantee the
> task delays for the desired time. Remove the definition of Wait().
>
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
>
>
> --- linux-vanilla/drivers/net/pcmcia/xirc2ps_cs.c 2004-06-15 22:19:13.000000000 -0700
> +++ linux-dev/drivers/net/pcmcia/xirc2ps_cs.c 2004-07-27 11:33:27.000000000 -0700
> @@ -418,11 +418,6 @@ next_tuple(client_handle_t handle, tuple
> #define PutByte(reg,value) outb((value), ioaddr+(reg))
> #define PutWord(reg,value) outw((value), ioaddr+(reg))
>
> -#define Wait(n) do { \
> - set_current_state(TASK_UNINTERRUPTIBLE); \
> - schedule_timeout(n); \
> -} while (0)
> -
> /*====== Functions used for debugging =================================*/
> #if defined(PCMCIA_DEBUG) && 0 /* reading regs may change system status */
> static void
> @@ -1716,13 +1711,13 @@ hardreset(struct net_device *dev)
>
> SelectPage(4);
> udelay(1);
> - Wait(HZ/25); /* wait 40 msec */
> + msleep(40); /* wait 40msec */
> if (local->mohawk)
> PutByte(XIRCREG4_GPR1, 1); /* set bit 0: power up */
> else
> PutByte(XIRCREG4_GPR1, 1 | 4); /* set bit 0: power up, bit 2: AIC */
> - Wait(HZ/50); /* wait 20 msec */
> + msleep(20); /* wait 20msec */
> }
>
> static void
> @@ -1736,9 +1731,9 @@ do_reset(struct net_device *dev, int ful
patching file drivers/net/pcmcia/xirc2ps_cs.c
patch: **** malformed patch at line 126: @@ -1736,9 +1731,9 @@ do_reset(struct net_device *dev, int ful
please do resend this one.
thanks maks
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2004-08-14 19:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-27 18:37 [Kernel-janitors] [PATCH] net/xirc2ps_cs: replace Nishanth Aravamudan
2004-08-14 19:09 ` maximilian attems [this message]
2004-08-16 19:55 ` Nishanth Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040814190930.GL1756@stro.at \
--to=janitor@sternwelten.at \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.