All of lore.kernel.org
 help / color / mirror / Atom feed
From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] Re: 2.6.8.1-kjt1
Date: Sun, 15 Aug 2004 17:04:52 +0000	[thread overview]
Message-ID: <20040815170452.GA2578@masina.coderock.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 971 bytes --]

On 15/08/04 15:55 +0200, maximilian attems wrote:
> msleep-drivers_net_slip.patch

  CC [M]  drivers/net/slip.o
  drivers/net/slip.c: In function `slip_exit':
  drivers/net/slip.c:1394: warning: implicit declaration of function `msleep'


Added include, to fix this:


Original from Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Domen Puncer <domen@coderock.org>

--- c/drivers/net/slip.c	Sat Aug 14 10:56:36 2004
+++ a/drivers/net/slip.c	Sun Aug 15 18:58:28 2004
@@ -74,6 +74,7 @@
 #include <linux/if_arp.h>
 #include <linux/if_slip.h>
 #include <linux/init.h>
+#include <linux/delay.h>
 #include "slip.h"
 #ifdef CONFIG_INET
 #include <linux/ip.h>
@@ -1390,10 +1391,8 @@ static void __exit slip_exit(void)
 	/* First of all: check for active disciplines and hangup them.
 	 */
 	do {
-		if (busy) {
-			set_current_state(TASK_INTERRUPTIBLE);
-			schedule_timeout(HZ / 10);
-		}
+		if (busy)
+			msleep(100);
 
 		busy = 0;
 		for (i = 0; i < slip_maxdev; i++) {

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

             reply	other threads:[~2004-08-15 17:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-15 17:04 Domen Puncer [this message]
2004-08-15 18:21 ` [Kernel-janitors] Re: 2.6.8.1-kjt1 maximilian attems
2004-08-17  9:21 ` Domen Puncer
2004-08-17 10:45 ` maximilian attems

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040815170452.GA2578@masina.coderock.org \
    --to=domen@coderock.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.