From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S267398AbUHPDfz (ORCPT ); Sun, 15 Aug 2004 23:35:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S267401AbUHPDfz (ORCPT ); Sun, 15 Aug 2004 23:35:55 -0400 Received: from mx1.elte.hu ([157.181.1.137]:12690 "EHLO mx1.elte.hu") by vger.kernel.org with ESMTP id S267398AbUHPDfq (ORCPT ); Sun, 15 Aug 2004 23:35:46 -0400 Date: Mon, 16 Aug 2004 05:36:23 +0200 From: Ingo Molnar To: Lee Revell Cc: Florian Schmidt , linux-kernel , Felipe Alfaro Solana Subject: Re: [patch] voluntary-preempt-2.6.8.1-P0 Message-ID: <20040816033623.GA12157@elte.hu> References: <1092382825.3450.19.camel@mindpipe> <20040813104817.GI8135@elte.hu> <1092432929.3450.78.camel@mindpipe> <20040814072009.GA6535@elte.hu> <20040815115649.GA26259@elte.hu> <20040816022554.16c3c84a@mango.fruits.de> <1092622121.867.109.camel@krustophenia.net> <20040816023655.GA8746@elte.hu> <1092624221.867.118.camel@krustophenia.net> <20040816032806.GA11750@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040816032806.GA11750@elte.hu> User-Agent: Mutt/1.4.1i X-ELTE-SpamVersion: MailScanner 4.31.6-itk1 (ELTE 1.2) SpamAssassin 2.63 ClamAV 0.73 X-ELTE-VirusStatus: clean X-ELTE-SpamCheck: no X-ELTE-SpamCheck-Details: score=-4.9, required 5.9, autolearn=not spam, BAYES_00 -4.90 X-ELTE-SpamLevel: X-ELTE-SpamScore: -4 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org doh - i think i found a brown-paperbag bug. could you change this code in kernel/sched.c: int __sched voluntary_resched(void) { #ifdef CONFIG_DEBUG_SPINLOCK_SLEEP __might_sleep(__FILE__, __LINE__); #endif if (kernel_preemption || !voluntary_preemption) return 0; to: int __sched voluntary_resched(void) { #ifdef CONFIG_DEBUG_SPINLOCK_SLEEP __might_sleep(__FILE__, __LINE__); #endif if (!voluntary_preemption) return 0; Does the mlockall xrun still occur? Ingo