Re: recent sym2 breakage

[Matthew Wilcox <willy@debian.org>]

On Mon, Aug 16, 2004 at 12:01:46AM -0700, Andrew Morton wrote:
> It runs OK, but a `halt -p' spits nasty messages, then hangs.
> 
> Can someone suggest what changes caused this?

Reviewing the diff between 2.6.7 and 2.6.8.1 doesn't show any significant
changes to the sym2 driver (lots of 0/NULL changes, and ppc64 is weird,
but not /that/ weird ;-)

So it must be something sym2 is using.  The obvious candidate is the
change to drivers/scsi/scsi_transport_spi.c in the spi_dv_retrain
function.  If you pull that out, does it work better?

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain