All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@kernel.crashing.org>
To: Greg Weeks <greg.weeks@timesys.com>
Cc: Dan Malek <dan@embeddededge.com>,
	Kumar Gala <kumar.gala@freescale.com>,
	LKML <linux-kernel@vger.kernel.org>,
	LinuxPPC-dev Development <linuxppc-dev@lists.linuxppc.org>
Subject: Re: [BUG] PPC math-emu multiply problem
Date: Mon, 16 Aug 2004 11:35:02 -0700	[thread overview]
Message-ID: <20040816183502.GC7303@smtp.west.cox.net> (raw)
In-Reply-To: <4120FCD0.2090305@timesys.com>

On Mon, Aug 16, 2004 at 02:28:32PM -0400, Greg Weeks wrote:

> Tom Rini wrote:
> 
> >>The way I got the LSB tests to pass was to remove the round in the 
> >>denormalised underflow case. This appears to match the hardware 
> >>behavior. I've not looked at the PPC floating point model close enough 
> >>to know if this is proper behavior. It is what the LSB tests are 
> >>expecting and doesn't cause a failure in any of the other LSB tests.
> >>   
> >>
> >
> >Have you guys run the LSB tests on some PPC with hw floating point (is
> >that what you mean by 'matches the hardware behavior' ?) to see if the
> >test also passes there as-is?  And does anyone object to this patch?
> >Now that 2.6.8.1 is out I'm gonna start committing in a bunch of stuff
> >I've had queued up and see if I can get Linus to pull.  Thanks.
> >
> > 
> >
> I didn't run the entire LSB, just some of the math tests. I had an 8260 
> and the 8560 we found the problem on and also a normal x86 box. I think 
> this is the correct fix. At least all of the LSB math tests pass now and 
> the LTP float tests don't complain.

Just to be clear, with that patch, 8260, 8560 and x86 all agree on
results ?

-- 
Tom Rini
http://gate.crashing.org/~trini/

      reply	other threads:[~2004-08-16 18:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-29 13:14 [BUG] PPC math-emu multiply problem Greg Weeks
2004-07-29 14:06 ` Kumar Gala
2004-07-29 14:26   ` Greg Weeks
2004-07-29 19:22   ` Dan Malek
2004-07-29 19:47     ` La Monte H.P. Yarroll
2004-07-30 14:45     ` Greg Weeks
2004-07-30 15:23       ` Greg Weeks
2004-08-09 16:56         ` Tom Rini
2004-08-09 17:42           ` Dan Malek
2004-08-09 22:18             ` La Monte H.P. Yarroll
2004-08-09 22:23             ` Tom Rini
2004-08-16 13:02               ` Greg Weeks
2004-08-16 14:48                 ` Tom Rini
2004-08-16 18:28                   ` Greg Weeks
2004-08-16 18:35                     ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040816183502.GC7303@smtp.west.cox.net \
    --to=trini@kernel.crashing.org \
    --cc=dan@embeddededge.com \
    --cc=greg.weeks@timesys.com \
    --cc=kumar.gala@freescale.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.linuxppc.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.