From: "David S. Miller" <davem@redhat.com>
To: Patrick McHardy <kaber@trash.net>
Cc: herbert@gondor.apana.org.au, nuno.silva@vgertech.com,
linux-kernel@vger.kernel.org, master@sectorb.msk.ru,
netdev@oss.sgi.com
Subject: Re: 2.6.8-rc4-bk1 problem: unregister_netdevice: waiting for ppp0 to become free. Usage count = 1
Date: Sun, 22 Aug 2004 21:47:46 -0700 [thread overview]
Message-ID: <20040822214746.1efb3682.davem@redhat.com> (raw)
In-Reply-To: <4128941D.9030000@trash.net>
On Sun, 22 Aug 2004 14:39:57 +0200
Patrick McHardy <kaber@trash.net> wrote:
> Herbert Xu wrote:
>
> >Nuno Silva <nuno.silva@vgertech.com> wrote:
> >
> >
> >>The problem is in the QoS code. If I start ppp whithout the
> >>
> >>
> >
> >OK, this appears to be due to the changeset titled
> >
> >[PKT_SCHED]: Refcount qdisc->dev for __qdisc_destroy rcu-callback
> >
> >It adds a reference to dev.
> >
> >I don't see any code that cleans up that reference when the dev goes
> >down. So someone needs to add that similar to the code in net/core/dst.c.
> >
> >Patrick, could you please have a look at this?
> >
> The reference is dropped in __qdisc_destroy. The problem lies in the CBQ
> qdisc, it doesn't destroy the root-class and leaks the inner qdisc. These
> two patches for 2.4 and 2.6 fix the problem.
Awesome, good detective work guys.
Patch applied, thanks.
next prev parent reply other threads:[~2004-08-23 4:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-12 19:18 2.6.8-rc4-bk1 problem: unregister_netdevice: waiting for ppp0 to become free. Usage count = 1 Nuno Silva
2004-08-13 8:03 ` Vladimir B. Savkin
2004-08-13 20:35 ` Nuno Silva
2004-08-22 2:13 ` Nuno Silva
2004-08-22 5:25 ` David S. Miller
2004-08-22 8:02 ` Nuno Silva
2004-08-22 8:14 ` Herbert Xu
2004-08-22 12:39 ` Patrick McHardy
2004-08-23 4:47 ` David S. Miller [this message]
2004-08-26 16:46 ` Jurriaan
2004-08-23 17:56 ` Nuno Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040822214746.1efb3682.davem@redhat.com \
--to=davem@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=master@sectorb.msk.ru \
--cc=netdev@oss.sgi.com \
--cc=nuno.silva@vgertech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.