From: Jens Axboe <axboe@suse.de>
To: Peter Osterlund <petero2@telia.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Speed up the cdrw packet writing driver
Date: Mon, 23 Aug 2004 13:43:29 +0200 [thread overview]
Message-ID: <20040823114329.GI2301@suse.de> (raw)
In-Reply-To: <m33c2py1m1.fsf@telia.com>
On Sat, Aug 14 2004, Peter Osterlund wrote:
> Hi!
>
> This patch replaces the pd->bio_queue linked list with an rbtree. The
> list can get very long (>200000 entries on a 1GB machine), so keeping
> it sorted with a naive algorithm is far too expensive.
It looks like you are assuming that bio->bi_sector is unique which isn't
necessarily true. In that respect, list -> rbtree conversion isn't
trivial (or, at least it requires extra code to handle this).
--
Jens Axboe
next prev parent reply other threads:[~2004-08-23 11:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-14 19:13 [PATCH] Speed up the cdrw packet writing driver Peter Osterlund
2004-08-23 11:43 ` Jens Axboe [this message]
2004-08-23 16:07 ` Peter Osterlund
2004-08-24 20:29 ` Jens Axboe
2004-08-24 21:04 ` Peter Osterlund
2004-08-24 21:47 ` Andrew Morton
2004-08-24 21:57 ` Lee Revell
2004-08-29 13:52 ` Alan Cox
2004-08-24 22:03 ` Peter Osterlund
2004-08-24 22:56 ` Andrew Morton
2004-08-25 5:38 ` Peter Osterlund
2004-08-25 6:50 ` Jens Axboe
2004-08-28 9:59 ` Peter Osterlund
2004-08-28 13:07 ` Jens Axboe
2004-08-28 18:42 ` Peter Osterlund
2004-08-28 19:45 ` Andrew Morton
2004-08-28 20:57 ` Peter Osterlund
2004-08-28 21:23 ` Andrew Morton
2004-08-29 12:17 ` Peter Osterlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040823114329.GI2301@suse.de \
--to=axboe@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petero2@telia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.