All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Erik Rigtorp <erik@rigtorp.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] make swsusp produce nicer screen output
Date: Mon, 23 Aug 2004 19:42:18 +0200	[thread overview]
Message-ID: <20040823174217.GC603@openzaurus.ucw.cz> (raw)
In-Reply-To: <20040820152317.GA7118@linux.nu>

Hi!

> I made a small patch that makes swsusp produce a bit nicer screen output,
> it's still a little rough though.

Well, it looks nice, be sure to submit smooth version :-).

				Pavel

> @@ -85,10 +85,17 @@
>  
>  static void free_some_memory(void)
>  {
> -	printk("Freeing memory: ");
> -	while (shrink_all_memory(10000))
> -		printk(".");
> -	printk("|\n");
> +	int i = 0;
> +	char *p = "-\|/";
> +	
> +	printk("Freeing memory:  ");
> +	while (shrink_all_memory(10000)) {
> +		printk("\b%c", p[i]);
> +		i++;
> +		if (i > 3)
> +			i = 0;
> +	}
> +	printk("\bdone\n");
>  }

I'd leave dots here. Its usefull to see if it done something or not.

-- 
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms         


  parent reply	other threads:[~2004-08-23 17:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-20 15:23 [PATCH] make swsusp produce nicer screen output Erik Rigtorp
2004-08-21 23:42 ` Stefan Seyfried
2004-08-23 17:42 ` Pavel Machek [this message]
2004-08-23 20:08   ` Erik Rigtorp
2004-08-24 21:49     ` Pavel Machek
2004-08-27 10:55       ` Stefan Seyfried
2004-08-28 22:58         ` Pavel Machek
2004-08-29 13:54       ` Erik Rigtorp
2004-08-29 14:59         ` Stefan Seyfried
2004-08-29 15:20         ` Pavel Machek
2004-08-29 16:36         ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040823174217.GC603@openzaurus.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=erik@rigtorp.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.