All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Andi Kleen <ak@suse.de>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: Fix MTRR strings definition.
Date: Tue, 24 Aug 2004 12:22:45 +0100	[thread overview]
Message-ID: <20040824112245.GA7847@redhat.com> (raw)
In-Reply-To: <20040824131735.3980c21a.ak@suse.de>

On Tue, Aug 24, 2004 at 01:17:35PM +0200, Andi Kleen wrote:

 > > The extern definitions no longer exist.
 > Your patch was: 

Oops. I missed the x86-64 one as I thought you killed that when you
killed the i386 one.

		Dave

 > --- latest-FC2/include/asm-x86_64/mtrr.h~	2004-08-24 00:20:17.377436336 +0100
 > +++ latest-FC2/include/asm-x86_64/mtrr.h	2004-08-24 00:21:04.137327752 +0100
 > @@ -69,6 +69,19 @@
 >  #define MTRR_TYPE_WRBACK     6
 >  #define MTRR_NUM_TYPES       7
 >  
 > +#ifdef MTRR_NEED_STRINGS
 > +static char *mtrr_strings[MTRR_NUM_TYPES] =
 > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 > +{
 > +	"uncachable",		/* 0 */
 > +	"write-combining",	/* 1 */
 > +	"?",			/* 2 */
 > +	"?",			/* 3 */
 > +	"write-through",	/* 4 */
 > +	"write-protect",	/* 5 */
 > +	"write-back",		/* 6 */
 > +};
 > +#endif
 > +
 >  #ifdef __KERNEL__
 >  
 >  extern char *mtrr_strings[MTRR_NUM_TYPES];
 > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 > 
 > -Andi
---end quoted text---

      reply	other threads:[~2004-08-24 11:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-23 23:23 Fix MTRR strings definition Dave Jones
2004-08-24  6:17 ` Andi Kleen
2004-08-24 11:00   ` Dave Jones
2004-08-24 11:17     ` Andi Kleen
2004-08-24 11:22       ` Dave Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040824112245.GA7847@redhat.com \
    --to=davej@redhat.com \
    --cc=ak@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.