From: "David S. Miller" <davem@redhat.com>
To: Stephen Smalley <sds@epoch.ncsc.mil>
Cc: bunk@fs.tum.de, cherry@osdl.org, linux-kernel@vger.kernel.org,
jmorris@redhat.com
Subject: Re: 2.6.9-rc1: selinux/hooks.c: functions returning unassigned variables
Date: Tue, 24 Aug 2004 11:50:46 -0700 [thread overview]
Message-ID: <20040824115046.660ef050.davem@redhat.com> (raw)
In-Reply-To: <1093362104.1800.156.camel@moss-spartans.epoch.ncsc.mil>
On Tue, 24 Aug 2004 11:41:45 -0400
Stephen Smalley <sds@epoch.ncsc.mil> wrote:
> On Tue, 2004-08-24 at 11:33, Adrian Bunk wrote:
> > On Tue, Aug 24, 2004 at 08:19:28AM -0700, John Cherry wrote:
> > >...
> > > security/selinux/hooks.c:2825: warning: `ret' might be used uninitialized in this function
> > > security/selinux/hooks.c:2886: warning: `ret' might be used uninitialized in this function
> >
> >
> > This was
> > [NET]: Add skb_header_pointer, and use it where possible.
> >
> >
> > @Dave:
> > In both functions ret is returned, but line that assigned a value to ret
> > was removed.
Good catch. Patch applied, thanks Stephen.
prev parent reply other threads:[~2004-08-24 18:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-24 15:19 IA32 (2.6.8.1 - 2004-08-23.21.30) - 3 New warnings (gcc 3.2.2) John Cherry
2004-08-24 15:33 ` 2.6.9-rc1: selinux/hooks.c: functions returning unassigned variables Adrian Bunk
2004-08-24 15:41 ` Stephen Smalley
2004-08-24 18:50 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040824115046.660ef050.davem@redhat.com \
--to=davem@redhat.com \
--cc=bunk@fs.tum.de \
--cc=cherry@osdl.org \
--cc=jmorris@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sds@epoch.ncsc.mil \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.