From: Christoph Hellwig <hch@infradead.org>
To: Douglas Gilbert <dougg@torque.net>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [RFC] scsi_normalize_sense()
Date: Tue, 24 Aug 2004 16:42:53 +0100 [thread overview]
Message-ID: <20040824164253.A30010@infradead.org> (raw)
In-Reply-To: <41258F6A.6030606@torque.net>; from dougg@torque.net on Fri, Aug 20, 2004 at 03:43:06PM +1000
On Fri, Aug 20, 2004 at 03:43:06PM +1000, Douglas Gilbert wrote:
> Looking around the linux SCSI subsystem the handling
> of data in the sense buffer is haphazard. Most places
> ignore "deferred" errors (e.g. medium error reported
> later when write caching is on) and will break horribly
> if they every see the newer "descriptor" format.
>
> Descriptor format sense data is much cleaner (amongst
> other reason are that it doesn't have to carry around 20
> years of baggage). See SPC-3 revision 20a section 4.5
> at http://www.t10.org for more information.
>
> The sense format a SCSI device will use is controlled
> by the D_SENSE bit in the control mode page.
>
> Here is some code which I am proposing to put into
> scsi_lib.c to facilitate cleaner handling. I have been
> testing it out in sg3_utils-1.08 (beta) for the last
> week. Comments??
This looks good to me. Before submission for the kernel side
please massage it into the canonical kernel style, though.
next prev parent reply other threads:[~2004-08-24 15:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-20 5:43 [RFC] scsi_normalize_sense() Douglas Gilbert
2004-08-24 15:42 ` Christoph Hellwig [this message]
2004-08-24 16:04 ` Luben Tuikov
2004-08-24 20:15 ` Kai Makisara
2004-08-25 1:22 ` Douglas Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040824164253.A30010@infradead.org \
--to=hch@infradead.org \
--cc=dougg@torque.net \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.