From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S268132AbUHXRWw (ORCPT ); Tue, 24 Aug 2004 13:22:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S268088AbUHXRWw (ORCPT ); Tue, 24 Aug 2004 13:22:52 -0400 Received: from hqemgate00.nvidia.com ([216.228.112.144]:48138 "EHLO hqemgate00.nvidia.com") by vger.kernel.org with ESMTP id S268132AbUHXRWt (ORCPT ); Tue, 24 Aug 2004 13:22:49 -0400 Date: Tue, 24 Aug 2004 12:22:45 -0500 From: Terence Ripperda To: Bjorn Helgaas Cc: Terence Ripperda , Alan Cox , Michael Geithe , Linux Kernel Mailing List , mastergoon@gmail.com Subject: Re: 2.6.8.1-mm2 (nvidia breakage) Message-ID: <20040824172245.GJ1078@hygelac> Reply-To: Terence Ripperda References: <20040819092654.27bb9adf.akpm@osdl.org> <200408230930.18659.bjorn.helgaas@hp.com> <20040823190131.GC1303@hygelac> <200408240926.42665.bjorn.helgaas@hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200408240926.42665.bjorn.helgaas@hp.com> User-Agent: Mutt/1.4i X-Accept-Language: en X-Operating-System: Linux hrothgar 2.6.7 X-OriginalArrivalTime: 24 Aug 2004 17:22:47.0448 (UTC) FILETIME=[F989E980:01C489FE] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 24, 2004 at 09:26:42AM -0600, bjorn.helgaas@hp.com wrote: > To be pedantically clear about this, looking at pci_dev->irq before > calling pci_enable_device() is *guaranteed* to fail, regardless of > what the BIOS does. So nvidia users will have to use "pci=routeirq" > until there's a new version of the nvidia driver. ah, ok. thanks for clarifying. > I'm assuming your patch makes the driver call pci_enable_device() > before using either irq or BAR information. That's the best way > to future-proof the driver. yes, that's exactly what we've done. Thanks, Terence