From mboxrd@z Thu Jan 1 00:00:00 1970 From: "David S. Miller" Subject: Re: Linux 2.6.9-rc1 Date: Wed, 25 Aug 2004 16:44:01 -0700 Sender: netfilter-devel-bounces@lists.netfilter.org Message-ID: <20040825164401.12259308.davem@redhat.com> References: <412CDFEE.1010505@triplehelix.org> <20040825203206.GS5824@sunbeam.de.gnumonks.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: joshk@triplehelix.org, netfilter-devel@lists.netfilter.org, linux-kernel@vger.kernel.org Return-path: To: Harald Welte In-Reply-To: <20040825203206.GS5824@sunbeam.de.gnumonks.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netfilter-devel.vger.kernel.org On Wed, 25 Aug 2004 22:32:06 +0200 Harald Welte wrote: Harald, a question about this fix. > +__ip_nat_find_helper(const struct ip_conntrack_tuple *tuple) > +{ > + return LIST_FIND(&helpers, helper_cmp, struct ip_nat_helper *, tuple); > +} > + > +struct ip_nat_helper * > ip_nat_find_helper(const struct ip_conntrack_tuple *tuple) > { > struct ip_nat_helper *h; > > READ_LOCK(&ip_nat_lock); > - h = LIST_FIND(&helpers, helper_cmp, struct ip_nat_helper *, tuple); > + h = __ip_nat_find_helper(tuple); > READ_UNLOCK(&ip_nat_lock); > So we're converting over to using __ip_nat_find_helper(). > +EXPORT_SYMBOL(ip_nat_find_helper); And adding an export of ip_nat_find_helper (ie. without the two underscore prefix). Why? If we need to export one, then we need to export both. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266242AbUHYXpM (ORCPT ); Wed, 25 Aug 2004 19:45:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266525AbUHYXpM (ORCPT ); Wed, 25 Aug 2004 19:45:12 -0400 Received: from mx1.redhat.com ([66.187.233.31]:20181 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S266242AbUHYXof (ORCPT ); Wed, 25 Aug 2004 19:44:35 -0400 Date: Wed, 25 Aug 2004 16:44:01 -0700 From: "David S. Miller" To: Harald Welte Cc: joshk@triplehelix.org, linux-kernel@vger.kernel.org, netfilter-devel@lists.netfilter.org Subject: Re: Linux 2.6.9-rc1 Message-Id: <20040825164401.12259308.davem@redhat.com> In-Reply-To: <20040825203206.GS5824@sunbeam.de.gnumonks.org> References: <412CDFEE.1010505@triplehelix.org> <20040825203206.GS5824@sunbeam.de.gnumonks.org> X-Mailer: Sylpheed version 0.9.12 (GTK+ 1.2.10; sparc-unknown-linux-gnu) X-Face: "_;p5u5aPsO,_Vsx"^v-pEq09'CU4&Dc1$fQExov$62l60cgCc%FnIwD=.UF^a>?5'9Kn[;433QFVV9M..2eN.@4ZWPGbdi<=?[:T>y?SD(R*-3It"Vj:)"dP Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 25 Aug 2004 22:32:06 +0200 Harald Welte wrote: Harald, a question about this fix. > +__ip_nat_find_helper(const struct ip_conntrack_tuple *tuple) > +{ > + return LIST_FIND(&helpers, helper_cmp, struct ip_nat_helper *, tuple); > +} > + > +struct ip_nat_helper * > ip_nat_find_helper(const struct ip_conntrack_tuple *tuple) > { > struct ip_nat_helper *h; > > READ_LOCK(&ip_nat_lock); > - h = LIST_FIND(&helpers, helper_cmp, struct ip_nat_helper *, tuple); > + h = __ip_nat_find_helper(tuple); > READ_UNLOCK(&ip_nat_lock); > So we're converting over to using __ip_nat_find_helper(). > +EXPORT_SYMBOL(ip_nat_find_helper); And adding an export of ip_nat_find_helper (ie. without the two underscore prefix). Why? If we need to export one, then we need to export both.