From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S268473AbUHZKHv (ORCPT ); Thu, 26 Aug 2004 06:07:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S268032AbUHZKDS (ORCPT ); Thu, 26 Aug 2004 06:03:18 -0400 Received: from fw.osdl.org ([65.172.181.6]:5331 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S268026AbUHZKBM (ORCPT ); Thu, 26 Aug 2004 06:01:12 -0400 Date: Thu, 26 Aug 2004 02:59:04 -0700 From: Andrew Morton To: viro@parcelfarce.linux.theplanet.co.uk Cc: pmarques@grupopie.com, mpm@selenic.com, linux-kernel@vger.kernel.org, bcasavan@sgi.com Subject: Re: [PATCH] kallsyms data size reduction / lookup speedup Message-Id: <20040826025904.02bf4c0e.akpm@osdl.org> In-Reply-To: <20040825234345.GN21964@parcelfarce.linux.theplanet.co.uk> References: <1093406686.412c0fde79d4f@webmail.grupopie.com> <20040825173941.GJ5414@waste.org> <412CDE9D.3090609@grupopie.com> <20040825185854.GP31237@waste.org> <412CE3ED.5000803@grupopie.com> <20040825192922.GH21964@parcelfarce.linux.theplanet.co.uk> <412D236E.3030401@grupopie.com> <20040825234345.GN21964@parcelfarce.linux.theplanet.co.uk> X-Mailer: Sylpheed version 0.9.7 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org viro@parcelfarce.linux.theplanet.co.uk wrote: > > On Thu, Aug 26, 2004 at 12:40:30AM +0100, Paulo Marques wrote: > > That is why I kept a big *If* in that sentence. I'm quite new to all > > this, and I'm still reading a lot of source code. > > > > If the culprit is in fact seq_file, and seq_file can be improved in a > > way that works for everyone (not only kallsyms), then I also agree > > that is is the way to go. But hunting this down might prove that the > > problem is somewhere else. It is just too soon to draw conclusions. > > readprofile(1) ought to narrow it down with that kind of timing difference... c014696c do_anonymous_page 4 0.0133 c0133550 kallsyms_expand_symbol 17 0.1545 c026b78f __copy_user_intel 31 0.2039 c026a5ec vsnprintf 39 0.0283 c026a318 number 40 0.0552 c011d102 write_profile 79 0.7182 c0131f39 is_exported 3805 17.0628 c0104028 default_idle 4254 86.8163 00000000 total 8325 0.0025 It's all in the O(n) is_exported(). Rusty's fault ;)